Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Snapping endpoint #82

Merged
merged 5 commits into from
Jul 5, 2024
Merged

Conversation

mrkhan
Copy link
Collaborator

@mrkhan mrkhan commented May 23, 2024

Basic snapping functionality with

  • added test case to request for json only
  • added test case with driving profile

Copy link
Collaborator

@TheGreatRefrigerator TheGreatRefrigerator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would put the dist file build in a separate commit as well as the tests.

src/OrsSnap.js Outdated Show resolved Hide resolved
src/__tests__/OrsSnap.cy.js Outdated Show resolved Hide resolved
src/__tests__/OrsSnap.cy.js Show resolved Hide resolved
src/__tests__/OrsSnap.cy.js Show resolved Hide resolved
@mrkhan mrkhan force-pushed the feature/add-snapping-api branch from a9a3343 to d3641e8 Compare May 29, 2024 14:10
@codecov-commenter
Copy link

codecov-commenter commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.10%. Comparing base (e4cd5ac) to head (fd40e5e).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #82      +/-   ##
==========================================
+ Coverage   99.08%   99.10%   +0.01%     
==========================================
  Files          15       16       +1     
  Lines         328      334       +6     
  Branches       55       57       +2     
==========================================
+ Hits          325      331       +6     
  Misses          3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheGreatRefrigerator TheGreatRefrigerator force-pushed the feature/add-snapping-api branch from d3641e8 to fd40e5e Compare May 31, 2024 14:57
@TheGreatRefrigerator TheGreatRefrigerator force-pushed the feature/add-snapping-api branch from fd40e5e to 634eab6 Compare July 5, 2024 13:25
Copy link

sonarqubecloud bot commented Jul 5, 2024

@TheGreatRefrigerator TheGreatRefrigerator merged commit 0d235dc into main Jul 5, 2024
2 of 3 checks passed
@TheGreatRefrigerator TheGreatRefrigerator deleted the feature/add-snapping-api branch July 5, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants