Add file argument to get_nml_value #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordansread
reviewed
Jul 11, 2017
NAMESPACE
Outdated
| @@ -42,6 +42,7 @@ export(write_nml) | |||
| import(GLMr) | |||
There was a problem hiding this comment.
I think keeping this import(GLMr) swamps the function-specific import you added below. Or at least that is my understanding of the namespacing
There was a problem hiding this comment.
Right. I made sure to make all imports specific in 9375e77
jordansread
requested changes
Jul 14, 2017
|
@jread-usgs Incremented and good to go. |
|
Nice, sorry - didn't see this until now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #233