Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We prefer smaller PRs that merge more often.
Haiku-length summary
terraform changes
for sandboxes, still so small
jemison fits in
Additional details
We want a better TF for deploying to multiple environments. However, this allows a developer to push Jemison to Cloud.gov if the credentials are configured correctly.
A deploy comes in at 990MB, which might make it in a 1GB sandbox. We have 2GB at the moment, so there's a bit of space, but really... the purpose of this is just so we can have a live demo. The PR brings the changes in that make sure things build and deploy. No changes to application code, and most of this should/will go away with proper DevOps/TF work.
No issue was ticketed for this. Arguably supports #86, #85.
To test, you need to get credentials, set up a
.tfvars
file, be logged into cloud.gov/cf... perhaps better to pair. A link to the live demo might be sufficient (see Slack).PR Checklist: Submitter
main
into your branch shortly before creating the PR. (You should also be mergingmain
into your branch regularly during development.)PR Checklist: Reviewer
make macup ; make e2e"
(FIXME)The larger the PR, the stricter we should be about these points.