Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes deploy to Cloud.gov #99

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Fixes deploy to Cloud.gov #99

wants to merge 8 commits into from

Conversation

jadudm
Copy link
Contributor

@jadudm jadudm commented Jan 25, 2025

We prefer smaller PRs that merge more often.

Haiku-length summary

terraform changes
for sandboxes, still so small
jemison fits in

Additional details

We want a better TF for deploying to multiple environments. However, this allows a developer to push Jemison to Cloud.gov if the credentials are configured correctly.

A deploy comes in at 990MB, which might make it in a 1GB sandbox. We have 2GB at the moment, so there's a bit of space, but really... the purpose of this is just so we can have a live demo. The PR brings the changes in that make sure things build and deploy. No changes to application code, and most of this should/will go away with proper DevOps/TF work.

No issue was ticketed for this. Arguably supports #86, #85.

To test, you need to get credentials, set up a .tfvars file, be logged into cloud.gov/cf... perhaps better to pair. A link to the live demo might be sufficient (see Slack).

PR Checklist: Submitter

  • Link to an issue if possible. If there’s no issue, describe what your branch does. Even if there is an issue, a brief description in the PR is still useful.
  • List any special steps reviewers have to follow to test the PR. For example, adding a local environment variable, creating a local test file, etc.
  • For extra credit, submit a screen recording like this one.
  • Make sure you’ve merged main into your branch shortly before creating the PR. (You should also be merging main into your branch regularly during development.)
  • Make sure that whatever feature you’re adding has tests that cover the feature. This includes test coverage to make sure that the previous workflow still works, if applicable.
  • Make sure the E2E tests pass.
  • Do manual testing locally.
    • If that’s not applicable for some reason, check this box.
  • Once a PR is merged, keep an eye on it until it’s deployed to dev, and do enough testing on dev to verify that it deployed successfully, the feature works as expected, and the happy path for the broad feature area still works.

PR Checklist: Reviewer

  • Pull the branch to your local environment and run make macup ; make e2e" (FIXME)
  • Manually test out the changes locally
    • Check this box if not applicable in this case.
  • Check that the PR has appropriate tests.

The larger the PR, the stricter we should be about these points.

Most of the issues were in the configuration of the space. Not sure if
those would normally be fixed in TF, or are part of the initial space
setup, and therefore manual.
I thought these configs were fixed. My concern at this point is that the
fix is in another branch.

This fix adds the service names to the `cf` configs. Critical for being
able to succesfully deploy.
This also makes the template for serve work.
Copy link
Contributor

@IsabelLaurenceau IsabelLaurenceau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IsabelLaurenceau IsabelLaurenceau self-requested a review January 29, 2025 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants