Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the interconnection-component-linked-has-protocol constraint #1092

Conversation

DimitriZhurkin
Copy link

@DimitriZhurkin DimitriZhurkin commented Jan 10, 2025

Committer Notes

This constraint tests the following scenario:
The "used-by" linked interconnection components have at least one protocol assembly.

Related issue: #930.

All Submissions:

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

@DimitriZhurkin DimitriZhurkin requested a review from a team as a code owner January 10, 2025 21:22
@DimitriZhurkin DimitriZhurkin self-assigned this Jan 10, 2025
wandmagic
wandmagic previously approved these changes Jan 13, 2025
Copy link
Contributor

@Gabeblis Gabeblis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This constraint fails when there are multiple "interconnection" components. Take a look at inventory-item-has-scan-type in fedramp-external-constraints.xml, as a similar approach could be used to write this constraint.

@Gabeblis Gabeblis force-pushed the add-interconnection-component-linked-has-protocol branch 2 times, most recently from 7d3ce4c to 016cf82 Compare January 16, 2025 03:58
@DimitriZhurkin DimitriZhurkin force-pushed the add-interconnection-component-linked-has-protocol branch from 016cf82 to e7b639b Compare January 16, 2025 21:01
@DimitriZhurkin DimitriZhurkin merged commit fc633b3 into GSA:develop Jan 22, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Components representing inter-boundary communication need to declare the direction of data flow
4 participants