Feature/all valid test #896

wandmagic · 2024-11-13T15:23:03Z

Committer Notes

Provides an extra test for all valid documents which we can add to. IE fedramp tamples awesome cloud etc...

All Submissions:

Have you selected the correct base branch per Contributing guidance?
Have you set "Allow edits and access to secrets by maintainers"?
Have you checked to ensure there aren't other open Pull Requests for the same update/change?
Have you squashed any non-relevant commits and commit messages? [instructions]
Have you added an explanation of what your changes do and why you'd like us to include them?
If applicable, have all FedRAMP Documents Related to OSCAL Adoption affected by the changes in this issue have been updated.?
If applicable, does this PR reference the issue it addresses and explain how it addresses the issue?

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

Co-Authored-By: Gabeblis <[email protected]>

features/fedramp_extensions.feature

package.json

src/validations/module.mk

Co-authored-by: A.J. Stein <[email protected]>

package.json

src/validations/constraints/fedramp-external-constraints.xml

src/validations/constraints/content/ssp-all-VALID.xml

Co-authored-by: Gabeblis <[email protected]>

Co-Authored-By: Gabeblis <[email protected]>

Co-authored-by: A.J. Stein <[email protected]>

Co-authored-by: Gabeblis <[email protected]>

aj-stein-gsa

Can you please rebase and not merge commits? They will block changes on feature branches.

features/steps/fedramp_extensions_steps.ts

stale

aj-stein-gsa · 2024-11-18T21:35:40Z

I am sorry to do this to you, but if you want we can hold for the third approval and then we can rebase and merge after that, @wandmagic.

wandmagic · 2024-11-19T17:24:37Z

I am sorry to do this to you, but if you want we can hold for the third approval and then we can rebase and merge after that, @wandmagic.

looks like rebasing dismissed the reviews

wandmagic and others added 2 commits November 13, 2024 10:18

all valid test

1e19a2a

make ssp all valid

f382bd5

Co-Authored-By: Gabeblis <[email protected]>

wandmagic requested a review from a team as a code owner November 13, 2024 15:23

wandmagic and others added 2 commits November 13, 2024 10:25

update oscal version

e91eed1

Co-Authored-By: Gabeblis <[email protected]>

Update fedramp_extensions.feature

56464d5

Co-Authored-By: Gabeblis <[email protected]>

aj-stein-gsa requested changes Nov 14, 2024

View reviewed changes

features/fedramp_extensions.feature Outdated Show resolved Hide resolved

package.json Outdated Show resolved Hide resolved

src/validations/module.mk Outdated Show resolved Hide resolved

aj-stein-gsa assigned wandmagic Nov 14, 2024

aj-stein-gsa added devops type: backlog item For developer work that is not part of a user-facing epic or user story. scope: constraints labels Nov 14, 2024

aj-stein-gsa added this to the Digital Authorization Phase 1 milestone Nov 14, 2024

wandmagic and others added 2 commits November 14, 2024 00:26

Update fedramp_extensions.feature

03e79c2

Co-authored-by: A.J. Stein <[email protected]>

Update module.mk

98fcff0

Co-authored-by: A.J. Stein <[email protected]>

aj-stein-gsa previously approved these changes Nov 14, 2024

View reviewed changes

package.json Outdated Show resolved Hide resolved

wandmagic dismissed aj-stein-gsa’s stale review via b1fdefb November 14, 2024 14:53

add integration npm commands

b1fdefb

aj-stein-gsa previously approved these changes Nov 14, 2024

View reviewed changes

Gabeblis previously requested changes Nov 14, 2024

View reviewed changes

src/validations/constraints/fedramp-external-constraints.xml Outdated Show resolved Hide resolved

src/validations/constraints/content/ssp-all-VALID.xml Outdated Show resolved Hide resolved

Update fedramp-external-constraints.xml

753b400

Co-authored-by: Gabeblis <[email protected]>

wandmagic dismissed aj-stein-gsa’s stale review via 753b400 November 14, 2024 21:44

wandmagic and others added 10 commits November 14, 2024 16:50

get latest ssp-all valid

ec9273b

all valid test

deb1fd4

make ssp all valid

b67d4c7

Co-Authored-By: Gabeblis <[email protected]>

update oscal version

2df64a4

Co-Authored-By: Gabeblis <[email protected]>

Update fedramp_extensions.feature

646eb73

Co-Authored-By: Gabeblis <[email protected]>

Update fedramp_extensions.feature

bd4ee17

Co-authored-by: A.J. Stein <[email protected]>

Update module.mk

4283e07

Co-authored-by: A.J. Stein <[email protected]>

add integration npm commands

184b625

Update fedramp-external-constraints.xml

4f93113

Co-authored-by: Gabeblis <[email protected]>

get latest ssp-all valid

f7ad94e

aj-stein-gsa requested changes Nov 15, 2024

View reviewed changes

wandmagic force-pushed the feature/all-valid-test branch from 1a646c5 to d8a043f Compare November 15, 2024 03:46

update from latest

d8a043f

aj-stein-gsa previously approved these changes Nov 15, 2024

View reviewed changes

aj-stein-gsa requested review from Gabeblis and a team November 15, 2024 15:29

wandmagic dismissed aj-stein-gsa’s stale review via 6799abb November 18, 2024 14:20

wandmagic force-pushed the feature/all-valid-test branch from 6799abb to 78c214a Compare November 18, 2024 14:21

update from develop

78c214a

Gabeblis reviewed Nov 18, 2024

View reviewed changes

features/steps/fedramp_extensions_steps.ts Outdated Show resolved Hide resolved

use env variable to control quiet

d6e7db3

wandmagic requested a review from Gabeblis November 18, 2024 16:59

Gabeblis previously approved these changes Nov 18, 2024

View reviewed changes

aj-stein-gsa previously approved these changes Nov 18, 2024

View reviewed changes

Rene2mt previously approved these changes Nov 19, 2024

View reviewed changes

wandmagic dismissed stale reviews from Rene2mt, aj-stein-gsa, and Gabeblis via 48a3344 November 19, 2024 17:23

wandmagic force-pushed the feature/all-valid-test branch from 48a3344 to 722e42e Compare November 19, 2024 17:28

update from develop

722e42e

Gabeblis approved these changes Nov 19, 2024

View reviewed changes

Gabeblis requested review from aj-stein-gsa and Rene2mt November 19, 2024 18:24

aj-stein-gsa approved these changes Nov 19, 2024

View reviewed changes

aj-stein-gsa requested a review from a team November 19, 2024 22:08

DimitriZhurkin approved these changes Nov 20, 2024

View reviewed changes

Gabeblis merged commit 595e071 into GSA:develop Nov 20, 2024
6 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/all valid test #896

Feature/all valid test #896

wandmagic commented Nov 13, 2024 •

edited

Loading

aj-stein-gsa left a comment

aj-stein-gsa commented Nov 18, 2024

wandmagic commented Nov 19, 2024

Feature/all valid test #896

Feature/all valid test #896

Conversation

wandmagic commented Nov 13, 2024 • edited Loading

Committer Notes

All Submissions:

aj-stein-gsa left a comment

Choose a reason for hiding this comment

aj-stein-gsa commented Nov 18, 2024

wandmagic commented Nov 19, 2024

wandmagic commented Nov 13, 2024 •

edited

Loading