Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing levels to constraints #915

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

Gabeblis
Copy link
Contributor

Committer Notes

Purpose

This PR aims to add the missing @level attribute to several constraints in the fedramp-external-constraints.xml file.

Changes

  • Added level="ERROR" to constraints that were missing the @level attribute.

All Submissions:

  • Have you selected the correct base branch per Contributing guidance?
  • Have you set "Allow edits and access to secrets by maintainers"?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you squashed any non-relevant commits and commit messages? [instructions]
  • Have you added an explanation of what your changes do and why you'd like us to include them?
    - [ ] If applicable, have all FedRAMP Documents Related to OSCAL Adoption affected by the changes in this issue have been updated.? No documentation is needed for this change as it is a minor correction to a file.
    - [ ] If applicable, does this PR reference the issue it addresses and explain how it addresses the issue? No issues necessary.

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

@Gabeblis Gabeblis self-assigned this Nov 19, 2024
@Gabeblis Gabeblis requested a review from a team as a code owner November 19, 2024 15:39
aj-stein-gsa
aj-stein-gsa previously approved these changes Nov 19, 2024
Copy link
Contributor

@aj-stein-gsa aj-stein-gsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, thanks for the catch.

DimitriZhurkin
DimitriZhurkin previously approved these changes Nov 19, 2024
@Gabeblis Gabeblis requested a review from a team November 19, 2024 16:18
@Gabeblis Gabeblis merged commit 2b0b880 into GSA:develop Nov 19, 2024
6 checks passed
@Gabeblis Gabeblis deleted the constraints/add-missing-levels branch November 19, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants