-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Example SSP #953
Merged
Merged
Add Example SSP #953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gabeblis
force-pushed
the
constraints/example-ssp
branch
from
December 3, 2024 17:39
6949854
to
4f42fa3
Compare
wandmagic
force-pushed
the
constraints/example-ssp
branch
from
December 3, 2024 18:53
0017ac4
to
310e542
Compare
aj-stein-gsa
requested changes
Dec 3, 2024
aj-stein-gsa
requested changes
Dec 3, 2024
src/validations/constraints/content/fedramp-ssp-example.oscal.xml
Outdated
Show resolved
Hide resolved
Gabeblis
force-pushed
the
constraints/example-ssp
branch
from
December 3, 2024 19:12
bd3433a
to
b88f36b
Compare
wandmagic
previously approved these changes
Dec 3, 2024
7 tasks
Per discussion while pairing earlier today, @wandmagic asked me to integrate the changes in #952 here, so I will work towards a PR to wrap in here. |
…aml pass file to example ssp
…aml pass file to example ssp
Gabeblis
force-pushed
the
constraints/example-ssp
branch
from
December 3, 2024 21:42
b88f36b
to
832afc9
Compare
aj-stein-gsa
reviewed
Dec 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, strong start. I have a general approach question/comment, but I can be happily overruled on that.
src/validations/constraints/content/fedramp-ssp-example.oscal.xml
Outdated
Show resolved
Hide resolved
Gabeblis
force-pushed
the
constraints/example-ssp
branch
from
December 3, 2024 22:49
b88f36b
to
f252201
Compare
Gabeblis
force-pushed
the
constraints/example-ssp
branch
from
December 3, 2024 23:24
f252201
to
3c3f936
Compare
aj-stein-gsa
approved these changes
Dec 4, 2024
wandmagic
approved these changes
Dec 4, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Committer Notes
Purpose
This PR aims to add a new example SSP.
Changes
fedramp-example-ssp.xml
was added to the content folder.ssp-all-VALID.xml
under integration testing for now because future constraints will no longer be valid against this file as we shift towards usingfedramp-example-ssp.xml
.dev-constraint.js
file. A conditional statement was added that if the model is SSP, then point to the newfedramp-example-ssp.xml
file. This preserves it's intended functionality for when we start writing constraints against other models, while also pointing to our new SSP example file when writing constraints against an SSP in the meantime.All Submissions:
- [ ] If applicable, have all FedRAMP Documents Related to OSCAL Adoption affected by the changes in this issue have been updated.?Not applicable.- [ ] If applicable, does this PR reference the issue it addresses and explain how it addresses the issue?Not applicable.By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.