Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Example SSP #953

Merged
merged 6 commits into from
Dec 4, 2024
Merged

Add Example SSP #953

merged 6 commits into from
Dec 4, 2024

Conversation

Gabeblis
Copy link
Contributor

@Gabeblis Gabeblis commented Dec 3, 2024

Committer Notes

Purpose

This PR aims to add a new example SSP.

Changes

  • fedramp-example-ssp.xml was added to the content folder.
  • feature file was edited to comment out ssp-all-VALID.xml under integration testing for now because future constraints will no longer be valid against this file as we shift towards using fedramp-example-ssp.xml.
  • Test scaffolding function was edited in the dev-constraint.js file. A conditional statement was added that if the model is SSP, then point to the new fedramp-example-ssp.xml file. This preserves it's intended functionality for when we start writing constraints against other models, while also pointing to our new SSP example file when writing constraints against an SSP in the meantime.

All Submissions:

  • Have you selected the correct base branch per Contributing guidance?
  • Have you set "Allow edits and access to secrets by maintainers"?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you squashed any non-relevant commits and commit messages? [instructions]
  • Have you added an explanation of what your changes do and why you'd like us to include them?
    - [ ] If applicable, have all FedRAMP Documents Related to OSCAL Adoption affected by the changes in this issue have been updated.? Not applicable.
    - [ ] If applicable, does this PR reference the issue it addresses and explain how it addresses the issue? Not applicable.

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

@Gabeblis Gabeblis self-assigned this Dec 3, 2024
@Gabeblis Gabeblis requested a review from a team as a code owner December 3, 2024 17:25
@Gabeblis Gabeblis force-pushed the constraints/example-ssp branch from 6949854 to 4f42fa3 Compare December 3, 2024 17:39
@wandmagic wandmagic force-pushed the constraints/example-ssp branch from 0017ac4 to 310e542 Compare December 3, 2024 18:53
@Gabeblis Gabeblis force-pushed the constraints/example-ssp branch from bd3433a to b88f36b Compare December 3, 2024 19:12
wandmagic
wandmagic previously approved these changes Dec 3, 2024
@aj-stein-gsa
Copy link
Contributor

Per discussion while pairing earlier today, @wandmagic asked me to integrate the changes in #952 here, so I will work towards a PR to wrap in here.

Copy link
Contributor

@aj-stein-gsa aj-stein-gsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, strong start. I have a general approach question/comment, but I can be happily overruled on that.

@Gabeblis Gabeblis force-pushed the constraints/example-ssp branch from b88f36b to f252201 Compare December 3, 2024 22:49
@Gabeblis Gabeblis force-pushed the constraints/example-ssp branch from f252201 to 3c3f936 Compare December 3, 2024 23:24
@Gabeblis Gabeblis requested a review from aj-stein-gsa December 3, 2024 23:41
@wandmagic wandmagic merged commit 5f7ce81 into GSA:develop Dec 4, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants