Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Crowdin updates #1914

Merged
merged 3 commits into from
Jan 30, 2025
Merged

New Crowdin updates #1914

merged 3 commits into from
Jan 30, 2025

Conversation

andyholmes
Copy link
Collaborator

No description provided.

@ferdnyc
Copy link
Member

ferdnyc commented Jan 28, 2025

@andyholmes I noticed some changes to gsconnect-ci go by recently — I'm guessing one of them upgraded ESLint to version 9, perhaps?

Looks like we need to migrate our config file to the new format, to go with that version upgrade.

@andyholmes
Copy link
Collaborator Author

@andyholmes I noticed some changes to gsconnect-ci go by recently — I'm guessing one of them upgraded ESLint to version 9, perhaps?

Looks like we need to migrate our config file to the new format, to go with that version upgrade.

Oh right, sorry. I have that commit in the protocol v8 PR. I can do it this evening, or you can just cherrypick it.

@ferdnyc
Copy link
Member

ferdnyc commented Jan 29, 2025

@andyholmes Oops, well we may have duplicated work. See #1915.

@ferdnyc
Copy link
Member

ferdnyc commented Jan 29, 2025

(My fault, if so, I should've read your comment instead of banging on eslint.)

@andyholmes andyholmes merged commit 34ce84c into main Jan 30, 2025
4 checks passed
@andyholmes andyholmes deleted the l10n_main branch January 30, 2025 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants