Skip to content
This repository has been archived by the owner on Dec 1, 2023. It is now read-only.

Aide app #8

Open
wants to merge 37 commits into
base: main
Choose a base branch
from
Open

Aide app #8

wants to merge 37 commits into from

Conversation

laurencejackson
Copy link
Collaborator

@laurencejackson laurencejackson commented Mar 30, 2022

Refactors MRS code to be compatible with aide deployment using the aide-sdk.

Changes github actions workflows to use environment defined by Dockerfile instead of python venv

Documentation moved to /documents/

@github-actions
Copy link

github-actions bot commented Mar 30, 2022

Coverage

Coverage Report
FileStmtsMissCoverMissing
mrs
   MRSOperator.py16160%1–33
mrs/dicom
   series.py1134461%35, 54–57, 61–67, 74–77, 81–85, 92–93, 100–103, 110–111, 115–120, 128–129, 136–144, 149–157, 184, 190–191
   study.py1134461%41, 55–56, 60, 63, 66, 81, 99–105, 109–112, 116–122, 129–132, 136–142, 146–149, 162–166, 178–179, 218–219, 242–243
mrs/processing
   MRSJob.py3714089%56–57, 60–63, 97–99, 105–107, 161–163, 171–173, 217–219, 278–279, 308, 321, 330–331, 368–369, 435–436, 457–461, 493–494, 571, 672, 681–683
   MRSTask.py1644672%80–87, 92–93, 116–124, 136–138, 150–153, 163–194, 205–223, 261, 272, 303
mrs/reporting
   MRSNormalChart.py18950%14–15, 19–26
mrs/tools
   myemail.py974455%74–80, 86–87, 104–126, 156–173, 181
   tools.py1894576%37–42, 70, 77–80, 102–107, 126–128, 141–147, 162–167, 185–187, 199–203, 238, 302, 315–327
TOTAL109628874% 

Tests Skipped Failures Errors Time
15 2 💤 2 ❌ 0 🔥 1m 39s ⏱️

CONFIG_DIR = os.path.dirname(os.path.realpath(__file__)) # same dir as this file
VERSION = manifest['model_version']

if os.path.exists(APP_DATA_DIR):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens here in context of AIDE?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks for the APP_DATA_DIR inside the container the application runs in. The image does not have this folder so it will always create a new one.

SETTINGS = configparser.ConfigParser()

# This makes a list of config files for both server and local files
config_files = list(os.path.join(CONFIG_DIR, x) for x in os.listdir(CONFIG_DIR) if x.endswith('cfg'))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How are config files read in AIDE?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to above, the dicomserver config lives entirely within the container where the app runs. There is no configuration that extends beyond the container, other than the few bits in the manifest file.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants