Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buff daggers and replace wildcard imports #20

Merged
merged 3 commits into from
Dec 24, 2023
Merged

Buff daggers and replace wildcard imports #20

merged 3 commits into from
Dec 24, 2023

Conversation

Quetz4l
Copy link

@Quetz4l Quetz4l commented Dec 8, 2023

(It could change the balance)

BM dagger (for self usege):

  • 200 without debuff and 20 with the debuff (Soul Fray)

BMA - Glass Sacrificial Dagger (for self usege):

  • 500 without debuff and 50 with the debuff (Soul Fray)
  • + x2 blood for both with 10% (added)

BM dagger (for mobs):

  • calculate a value

BMA - Glass Dagger of Sacrifice (for mobs):
was: if some mobs value +100 else value =500 (villager +500)
now:

  • calculate a value and if mob is "villager" value +500 (2500) else value + 100 (added)
  • + x5 blood for villager with 30% (added)
  • + x5 blood for all except for the vanilla villagers with 20% (added)

added support for moon villagers and guardians

GTNewHorizons/GT-New-Horizons-Modpack#15044
GTNewHorizons/GT-New-Horizons-Modpack#15043

  • replaced all wildcard imports in the mod

Zereff06 added 3 commits December 8, 2023 21:02
For the daggers of sacrifice and for the sacrificial dagger
@chochem chochem added ongoing freeze - don't merge Not just a bug fix and thus affected by a current freeze for a upcoming version Affects Balance Requires admin approval before merging labels Dec 8, 2023
@Dream-Master Dream-Master requested a review from a team December 8, 2023 21:03
@Dream-Master
Copy link
Member

Is Soul Fray not a debuff to prevent players from sacrifice to death and can cheat in as much blood they want.
Can you list the values before your changes?

I am not sure if this is balanced.

@Quetz4l
Copy link
Author

Quetz4l commented Dec 8, 2023

Is Soul Fray not a debuff to prevent players from sacrifice to death and can cheat in as much blood they want. Can you list the values before your changes?

I am not sure if this is balanced.

I haven't changed mechanics since (Soul Fray).
In the PR description I described what was there, what I added and what in the blood magic.

@Dream-Master
Copy link
Member

ok but i dont see what are old values and what are the new ones. Like BM dagger (for self usege): old/new values etc

@Quetz4l
Copy link
Author

Quetz4l commented Dec 8, 2023

I didn't change the blood magic. I put it in the description to compare because there are 2 daggers each. One in blood magic and one in blood arsenal. In blood arsenal they are harder to make and should be better, I only changed them.

@Dream-Master
Copy link
Member

ok. so before they make no difference which dagger you have ?

@Quetz4l
Copy link
Author

Quetz4l commented Dec 8, 2023

Previously in blood arsenal daggers with mobs were worse, since the author did not take into account the inhabitants and set the exact value of 500 blood except for 4 types of mobs. These 4 types of mobs gave more by 100 each, while villages gave thousands less (guard gave 3500 less blood and etc.).

@Quetz4l
Copy link
Author

Quetz4l commented Dec 8, 2023

But the dagger for self gave more and worked better. BM 200, BMA 500

@Dream-Master
Copy link
Member

ok but isnt there a list how much each mob gives? I rember i saw a list long time ago (config)

@Quetz4l
Copy link
Author

Quetz4l commented Dec 8, 2023

these values are taken from Blood magic, then I add 100, 500 or multiply that value by 5

@Dream-Master
Copy link
Member

ok. guess it need to be discussed when feature freeze is over.

@Alastors
Copy link

Alastors commented Dec 8, 2023

Why wait until after the freeze? It's not new content?

@Quetz4l
Copy link
Author

Quetz4l commented Dec 8, 2023

Why wait until after the freeze? It's not new content?

It's a rebalancing and there's always room for unforeseen bugs.

@vovaksenov
Copy link

Looks good imo. Hopefully this helps with the pre-ritual mob spam a bit. I like the values.

@Dream-Master Dream-Master removed the ongoing freeze - don't merge Not just a bug fix and thus affected by a current freeze for a upcoming version label Dec 18, 2023
@Dream-Master Dream-Master merged commit b12923d into GTNewHorizons:master Dec 24, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Affects Balance Requires admin approval before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants