-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mana requirements indicator to the mana pool recipes #52
Add mana requirements indicator to the mana pool recipes #52
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an intentional major design decision of Botania and violates our magic integrity policy
I think it can be a nice option to see how much a recipe use instead of go to a wiki / view the code to find out how much it use. Sure we can think of a mechanic to unlock this with some magical research |
Current mana bar is accurate enough to meet the needs of the players if mana consumprion is big enought. This change is targeting players which works with low mana recipes. |
Honestly I'd make the argument that there isn't enough Botania integration to even think about this in that regards 🤷♂️ |
I'm with Alastors on this one, this was explicitly designed this way by the original author so I don't feel privileged enough to change that. |
In GTNH there exist some sets of recipes where mana consumption fluctuates so enought that it is hard to distinguish real values of mana requirements |
There is literally no difference between 1000 and 700 mana requirements on low level Botania crafts (according to NEI). That is bad. |
🤷♂️ it's neither bad nor good, it is simply the mechanic. |
Following up on this, just for case history and all of that, our policy is very explicit in its defense toward maintaining the artistic and mechanical design, here are the policies related to that. https://github.com/GTNewHorizons/GTNH-Dev-Doc/blob/master/developer's%20code%20of%20conduct.md
Likewise, I think the case history reflects negatively against changes like this: Going further, despite all of the changes Vazkii made against what his original promises were, the lack of distinct numbers in botania was one of the few things that remained. personal noteI do not state this out of malice, nor in attempt to dissuade you from pursuing magic development in general. I am ecstatic to see people passionate about magic in general, and I desperately hope to see you continue this passion in the future. Thank you for your contribution regardless of whether it makes it into the pack or not. |
Just a reminder, Alfheim (Botania addon) already implements numerical mana representation (config option). |
|
||
int mana = ((CachedManaPoolRecipe) arecipes.get(recipe)).mana; | ||
String manaRequired = Integer.toString(mana); | ||
FontRenderer font = Minecraft.getMinecraft().fontRenderer; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tab/spaces need to be fixed
|
||
GuiDraw.drawTexturedModalRect(45, 5, 38, 35, 92, 50); | ||
HUDHandler.renderManaBar(32, 63, 0x0000FF, 0.75F, mana, TilePool.MAX_MANA / 10); | ||
font.drawString(manaRequired, 84 - font.getStringWidth(manaRequired) / 2, 71, 0xFF03737F); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be eligible, this needs a config option that defaults to not showing the numerical mana value
We do not have to adhere to the specifications and standards of the original authors and are free to decide what fits into the GTNH and what does not. Everyone should think freely and break new ground. Thank you. |
I am with alastor and combusterf as well. This is antithetical to the basic design principles of botania that make people like the mod so much. |
I mean, I would be in favour. I get the original author hated it, but I can't really see a good reason to not allow us to peak into the inner workings so to speak. It just feels like "no because someone 10 years ago said so" which isn't really relevant anymore. |
I'm torn. The inability to see exact numbers are indeed thematical and the original design and all that, and it's nice and immersive when you're just doing simple stuff by hand imho, but as soon as you want to really use it for something, you'll likely start looking at wikis, source code or spreadsheets to get the actual numbers anyway. I guess I'm not against the idea of adding some form of item or research (botanical engineering - the science of mystery?) or something to unlock this at least. |
lets do it like thaumcraft show the full recipe with values when you researched it. |
PR may be rejected due to better solution #53 |
Closed as per request of the PR owner |
Oh... how to compare recipes with one pixel mana requirements... time to (test) fix
![image](https://private-user-images.githubusercontent.com/14280202/334950455-8ab93248-675f-4e63-94af-bdc131b3585e.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg5NjUxNDgsIm5iZiI6MTczODk2NDg0OCwicGF0aCI6Ii8xNDI4MDIwMi8zMzQ5NTA0NTUtOGFiOTMyNDgtNjc1Zi00ZTYzLTk0YWYtYmRjMTMxYjM1ODVlLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA3VDIxNDcyOFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTdmYTA4OGNhYjViNDYwODU4N2VmNGM0NzUzODgxYTZmZTBlYTNhMWYyYTk1ZmUxYjFhMmIwMmM5ODU1N2QwMmYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.DzyFPNCiM6NmhB224QkLkYXk6MWar3k2DcDDwwO1rxc)
Tested on one of the latest nightly builds.
Only client-side changes (buts also tested on dedicated server for sabity level stability)