Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

band aid fix if sun.reflect.Reflection cant be found #9

Merged
merged 2 commits into from
May 12, 2024
Merged

band aid fix if sun.reflect.Reflection cant be found #9

merged 2 commits into from
May 12, 2024

Conversation

AnAwesomGuy
Copy link
Contributor

note that i didnt test this and made it in the web interface

@Dream-Master Dream-Master requested a review from a team April 14, 2024 09:10
@Caedis
Copy link
Member

Caedis commented Apr 16, 2024

Got any error logs for the reason for this?
NoClassDefFoundError is handled by the Exception catch all

@Glease
Copy link

Glease commented Apr 17, 2024

@Caedis Error is not a subclass of Exception

@AnAwesomGuy
Copy link
Contributor Author

Got any error logs for the reason for this? NoClassDefFoundError is handled by the Exception catch all

what Glease said, and also sun.reflect.Reflection doesnt exist on all jdks
this is also just a bandaid fix, something better would be for hodgepodge to patch this to work on java 8+ by using StackWalker

@Caedis
Copy link
Member

Caedis commented Apr 17, 2024

Good to know. I swear i remember seeing an instanceof check for NoClassDefFoundError inside of a general Exception catch recently. Maybe that was checking the cause of the exception

@Caedis
Copy link
Member

Caedis commented Apr 17, 2024

@Dream-Master Dream-Master added ongoing freeze - don't merge Not just a bug fix and thus affected by a current freeze for a upcoming version and removed ongoing freeze - don't merge Not just a bug fix and thus affected by a current freeze for a upcoming version labels Apr 28, 2024
@Dream-Master
Copy link
Member

@AnAwesomGuy @Glease @Caedis any news here ?

@Dream-Master Dream-Master merged commit 0bd5fd4 into GTNewHorizons:master May 12, 2024
1 check passed
Dream-Master pushed a commit that referenced this pull request May 19, 2024
Co-authored-by: Martin Robertz <[email protected]>
(cherry picked from commit 0bd5fd4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants