Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix T8/T9 FluidCore research time #3340

Merged

Conversation

Kogepan229
Copy link
Contributor

Research time should double per tier and be equal to Fluid Cells.

@Dream-Master
Copy link
Member

This is a huge buff. Explain why.

@StaffiX
Copy link
Contributor

StaffiX commented Oct 7, 2024

  1. This pr was made to address an inconsistency
    up to tier 7, every fluid core doubled the scanning time, but then t8 and t9 cores had their time multiplied by 10
    this difference doesn't happen to fluid blocks itself, that these cores use to craft them, so this is an oversight most likely.

  2. due to Add scanner mode for research station TecTech#283, changing this doesn't actually have any effect, because a proper research station setup should be able to research it under a minute even without this "buff".
    (1 296 000 computation, 4 max sized research station in 2.6 would make that take 48 seconds, and in the betas, research station is 4x stronger by the time you get to the point where you have to make these items)

  3. This only changes the time it takes to research it, so just a one time thing to be able to craft it in the first place, this doesn't affect the actual crafting time

@Dream-Master Dream-Master requested a review from a team October 7, 2024 21:37
@serenibyss serenibyss added the enhancement Improve an existing mechanic. Please explain the change with a before/after comparison. label Oct 13, 2024
@Dream-Master Dream-Master enabled auto-merge (squash) October 13, 2024 15:31
@Dream-Master Dream-Master merged commit db698d7 into GTNewHorizons:master Oct 13, 2024
5 checks passed
@Kogepan229 Kogepan229 deleted the fix-fluidcore-research-time branch December 25, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve an existing mechanic. Please explain the change with a before/after comparison.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants