Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Pipe Swapping functionality #3836

Merged
merged 35 commits into from
Feb 1, 2025
Merged

Add Pipe Swapping functionality #3836

merged 35 commits into from
Feb 1, 2025
+134 −0

Conversation

mak8427
Copy link
Contributor

@mak8427 mak8427 commented Jan 20, 2025 •
edited
Loading

Add the same functionality discussed here but for pipes : #3826
-Feature: Swap different pipes with Sneaking+ leftclick

@Dream-Master Dream-Master requested a review from a team January 21, 2025 15:59
@Dream-Master Dream-Master added the 🚧 Testing on Zeta Do not merge yet, testing this PR on Zeta label Jan 21, 2025
@Dream-Master Dream-Master added the enhancement Improve an existing mechanic. Please explain the change with a before/after comparison. label Jan 22, 2025
@Dream-Master Dream-Master requested review from Lyfts and a team January 25, 2025 21:30
serenibyss
serenibyss reviewed Jan 25, 2025
View reviewed changes
Copy link
Member

@serenibyss serenibyss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other note: When swapping a pipe, all stored fluid is lost. I think it should at least transfer what it "can" fit, if not some other more creative solution to prevent voiding fluid accidentally

src/main/java/gregtech/api/metatileentity/implementations/MTEFluid.java Outdated Show resolved Hide resolved
src/main/java/gregtech/api/metatileentity/implementations/MTEFluid.java Outdated Show resolved Hide resolved
@mak8427
Copy link
Contributor Author

mak8427 commented Jan 28, 2025 •
edited
Loading

Todo:

  • fix multiplayer server compatibility
  • fit fluid into the pipe

@serenibyss serenibyss removed the 🚧 Testing on Zeta Do not merge yet, testing this PR on Zeta label Feb 1, 2025
@serenibyss serenibyss merged commit 98c7e6b into GTNewHorizons:master Feb 1, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serenibyss serenibyss serenibyss approved these changes

@Lyfts Lyfts Awaiting requested review from Lyfts

@Dream-Master Dream-Master Awaiting requested review from Dream-Master

Assignees
No one assigned
Labels
enhancement Improve an existing mechanic. Please explain the change with a before/after comparison.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mak8427 @Dream-Master @serenibyss @Lyfts