Rewrite CoAL recipe loader #3837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serenibyss
added
refactor
NotAPenguin0
approved these changes
Jan 25, 2025
serenibyss
removed
the
🚧 Testing on Zeta
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrites the CoAL recipe loader to be done by hand. Recipes are exactly identical to before aside from one difference, where the LuV Conveyor had no CoAL recipe with Styrene Butadiene Rubber, which it now does (this was an autogen failure).
Enables us to much more easily edit these recipes going forward, and have more granular control over individual recipes vs hacking apart a complex piece of autogen. Also removes another loop over a recipe map
getAllRecipes()call.Lastly this introduces an ore prefix for circuit wraps, so these have oredicts now. This is mostly for convenience in coding, but maybe someone will find a use for this.