Code

Cover refactor, part 1#3874

Code

Merged

YannickMG merged 23 commits intomasterGTNewHorizons/GT5-Unofficial:masterfrom cover-refactorGTNewHorizons/GT5-Unofficial:cover-refactorCopy head branch name to clipboardFeb 3, 2025

+139-442

Commits

Commits on Feb 1, 2025

• Cover ID and behavior are immutable

  YannickMG

  committed
  3899a0e

  Copy full SHA for 3899a0e

• Move allowsTickRateAddition to CoverInfo

  YannickMG

  committed
  d954826

  Copy full SHA for d954826

• Add CoverInfo::hasNoBehavior

  YannickMG

  committed
  6e1b92e

  Copy full SHA for 6e1b92e

• Move onCoverRightclickClient to CoverInfo

  YannickMG

  committed
  59cd72b

  Copy full SHA for 59cd72b

• Marked methods exposing CoverBehavior as deprecated

  YannickMG

  committed
  fcb3b4b

  Copy full SHA for fcb3b4b

• Add CoverInfo::createCoverContainer

  YannickMG

  committed
  a12ee70

  Copy full SHA for a12ee70

• Streamlined GTUIInfos::createCoverGuiContainer

  YannickMG

  committed
  02d796d

  Copy full SHA for 02d796d

• Encapsulate calls to isGUIClickable

  YannickMG

  committed
  dfd7b63

  Copy full SHA for dfd7b63

• Remove IControlsWorkCover::makeSureOnlyOne

  YannickMG

  committed
  cc2b16c

  Copy full SHA for cc2b16c

• Remove IControlsWorkCover. CoverControlsWork can check against itself, and CoverRedstoneTransmitterExternal is not incompatible with it.

  YannickMG

  committed
  e4e2d48

  Copy full SHA for e4e2d48

• Remove ICoverable::getCoverBehaviorAtSideNew

  YannickMG

  committed
  8cc4131

  Copy full SHA for 8cc4131

• Removed unused ICoverable methods

  YannickMG

  committed
  d5d7a34

  Copy full SHA for d5d7a34

• Removed ICoverable::getComplexCoverDataAtSide

  Show description for dfe83c6
  YannickMG

  committed
  dfe83c6

  Copy full SHA for dfe83c6

• Removed ICoverable::getCoverBehaviorAtSide

  Show description for b6fb59f
  YannickMG

  committed
  b6fb59f

  Copy full SHA for b6fb59f

• Removed ICoverable::getCoverDataAtSide

  YannickMG

  committed
  daf5bbb

  Copy full SHA for daf5bbb

Commits on Feb 2, 2025

• Minor MTECropHarvestor cleanup

  YannickMG

  committed
  df4071d

  Copy full SHA for df4071d

• createCoverGuiContainer doesn't really serve a meaningful purpose anymore

  YannickMG

  committed
  c7d4d9a

  Copy full SHA for c7d4d9a

• Don't use a WeakReference to populate a network packet. Still cleaner than the original code.

  YannickMG

  committed
  b905972

  Copy full SHA for b905972

• Actually, just remove un-overridden onCoverRightclickClient

  YannickMG

  committed
  b49f343

  Copy full SHA for b49f343

• Merge branch 'master' into cover-refactor

  YannickMG

  authored
  47882d3

  Copy full SHA for 47882d3

• Merge branch 'master' into cover-refactor

  YannickMG

  authored
  07c6f4b

  Copy full SHA for 07c6f4b

• Merge branch 'master' into cover-refactor

  Dream-Master

  authored
  a0e6149

  Copy full SHA for a0e6149

Commits on Feb 3, 2025

• Merge branch 'master' into cover-refactor

  YannickMG

  authored
  359ce82

  Copy full SHA for 359ce82