Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basalt to rock breaker #3875

Merged

Conversation

LazyFleshWasTaken
Copy link
Contributor

@LazyFleshWasTaken LazyFleshWasTaken commented Feb 1, 2025

Add basalt to rock breaker, mimicking newer vanilla, and as suggested in this comment: #14925

@Dream-Master Dream-Master requested a review from a team February 1, 2025 08:59
@Dream-Master Dream-Master added the new feature Add something new. Please explain in detail how it works. label Feb 1, 2025
@Dream-Master
Copy link
Member

make basalt out of pack ice sounds a bit wired @LazyFleshWasTaken

@LazyFleshWasTaken
Copy link
Contributor Author

It's not made of it, it's the catalyst for the reaction.

@Dream-Master
Copy link
Member

ah it use it?

@LazyFleshWasTaken
Copy link
Contributor Author

LazyFleshWasTaken commented Feb 1, 2025

It's not consumed. It was easier to place the ice as an item instead of making checks for a placed block of ice.

@Dream-Master Dream-Master added the 🚧 Testing on Zeta Do not merge yet, testing this PR on Zeta label Feb 1, 2025
@YannickMG
Copy link
Contributor

As an alternative to a non-consumed catalyst, could you have this machine replicate the setup for generating basalt in modern?
https://youtu.be/4MAxzmrRFm4?t=182

Basically if the circuit mode is set, it has ice on one side, lava and the other and soul sand underneath, then it would make Basalt? This would build upon this machine's unique mechanic of needing certain blocks around it.

@YannickMG
Copy link
Contributor

Oh and, unrelated but we should totally update the NEI handler to show the blocks needed around the machine.

@serenibyss serenibyss enabled auto-merge (squash) February 2, 2025 19:38
@serenibyss serenibyss removed the 🚧 Testing on Zeta Do not merge yet, testing this PR on Zeta label Feb 2, 2025
@serenibyss serenibyss merged commit 6ec36c0 into GTNewHorizons:master Feb 2, 2025
6 checks passed
@LazyFleshWasTaken LazyFleshWasTaken deleted the Rockbreaker-BasaltAdd branch February 2, 2025 19:44
@EnderProyects
Copy link
Contributor

@LazyFleshWasTaken Why did you use AmunRa basalt instead of GregTech basalt? it doesnt make much sense

@LazyFleshWasTaken
Copy link
Contributor Author

@LazyFleshWasTaken Why did you use AmunRa basalt instead of GregTech basalt? it doesnt make much sense

I didn't? It was showing as GT basalt on my instance.

@EnderProyects
Copy link
Contributor

image
Not anymore xd

@LazyFleshWasTaken
Copy link
Contributor Author

image Not anymore xd

:fail:
Unfortunately, idk how to solidify the output as GT basalt. 😢

@YannickMG
Copy link
Contributor

image
Looks like a general Ore Unification problem for Basalt.

@LazyFleshWasTaken
Copy link
Contributor Author

LazyFleshWasTaken commented Feb 3, 2025

Tbf, if the amun rap can be macerated down to dust, it doesn't really matter? You'd need to put gt basalt through a chisel anyway for decoration blocks.

@EnderProyects
Copy link
Contributor

okay... but you can´t macerate it xd

@LazyFleshWasTaken
Copy link
Contributor Author

okay... but you can´t macerate it xd

Ugh

@EnderProyects
Copy link
Contributor

Whatever, I think I can fix it and also add deepslate

@EnderProyects
Copy link
Contributor

image
Solved, now time to add deepslate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature Add something new. Please explain in detail how it works.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants