Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Thaumic Energistics support to the Apimancers drainer #37

Merged
merged 6 commits into from
Jan 28, 2024

Conversation

Quantumlyy
Copy link

This implementation was derived from an example in the Gadomancy mod.

@Dream-Master Dream-Master marked this pull request as ready for review January 28, 2024 10:34
@Dream-Master Dream-Master requested review from OneEyeMaker and a team January 28, 2024 10:34
@OneEyeMaker
Copy link

OneEyeMaker commented Jan 28, 2024

Looks good. But this implementation is not complete. ThE doesn't detect tile entities automatically - you need to manually register class that implements IAspectStorage.
Example for Gadomancy's Essentia Condenser: https://github.com/GTNewHorizons/ThaumicEnergistics/blob/master/src/main/java/thaumicenergistics/common/integration/tc/EssentiaTileContainerHelper.java#L387

In other words, you need to call (in post-init phase):

// do not copy this code ;)
if (Loader.isModLoaded("thaumicenergistics")) {
    // ToBothPermissions - input + output
    // There are also separate overloads for input and output
    ThEApi.instance().transportPermissions().addAspectStorageTileToBothPermissions(TileEntityApimancersDrainerCommon.class);
}

@Dream-Master Dream-Master merged commit dcfa448 into GTNewHorizons:master Jan 28, 2024
1 check passed
@Quantumlyy Quantumlyy deleted the drainer-energistics branch January 28, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants