Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Vambraces of Steady Progression not push the player up/down when the player is flying #51

Merged
merged 3 commits into from
May 13, 2024
Merged

Make Vambraces of Steady Progression not push the player up/down when the player is flying #51

merged 3 commits into from
May 13, 2024

Conversation

norbby42
Copy link

What it says on the tin: If the player is flying, then suppress the ladder "speed" adjustments. Fixes the player being pushed down when flying forward into certain blocks, like ME Cables.

@Dream-Master Dream-Master requested a review from a team May 13, 2024 05:39
Alastors
Alastors approved these changes May 13, 2024
View reviewed changes
Copy link

@Alastors Alastors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷 seems fine I suppose

@Dream-Master Dream-Master enabled auto-merge (squash) May 13, 2024 05:43
@Dream-Master Dream-Master merged commit 03010c2 into GTNewHorizons:master May 13, 2024
1 check passed
@norbby42 norbby42 deleted the patch-1 branch May 13, 2024 05:46
Dream-Master pushed a commit that referenced this pull request May 19, 2024
@norbby42 @Dream-Master
Make Vambraces of Steady Progression not push the player up/down when…
6c10469 
… the player is flying (#51)

* Vambraces of Steady Progression don't push down flying players

* Update ItemMagicalBaubles.java

* Apply spotless, fix using C++ style cast instead of Java, and move logic inside the Vambrace-specific block

(cherry picked from commit 03010c2)
@Dream-Master Dream-Master mentioned this pull request May 19, 2024
Closed
58 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alastors Alastors Alastors approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@norbby42 @Alastors @Dream-Master