Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Useful changes from my setup which I think may be beneficial to others #506

Closed
wants to merge 18 commits into from
+8,059 −26
Closed

Useful changes from my setup which I think may be beneficial to others #506

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
6246b9a
append imports option
Nov 30, 2017
e713147
update
Nov 30, 2017
b063c3f
import VALUE from obj[VALUE]
Apr 12, 2018
3b4e10e
proper sorting
Apr 12, 2018
1a7ee44
add computed keys in aliased desctructured constants
Apr 20, 2018
2c2f69e
Merge branch 'master' of https://github.com/Galooshi/import-js
May 31, 2018
0fd3a6d
added logic for checking files with export all from
Jun 1, 2018
e3a4b11
specify project root
Jun 9, 2018
52f9e0f
fixed the tests
Jun 10, 2018
9d3567e
performance improvement
Jun 19, 2018
7bceb5b
added test for aliases in destructured objects
Jul 3, 2018
124a792
added test for isRoot and info in the README
Jul 3, 2018
60fc13f
Merge branch 'append-imports'
Jul 19, 2018
f64afde
fixed the tests
Jul 19, 2018
89f5e4b
removed the export all logic for now
Jul 19, 2018
6b8657c
removed the dead code for exports all
Jul 20, 2018
ed94946
requested updates
Jul 23, 2018
4689499
initialize function
Jul 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/visitIdentifierNodes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ function normalizeNode(node, context) {
}

const isAssignment = KEYS_USED_FOR_ASSIGNMENT.has(key) ||
(key === 'key' && parent.parent.type === 'ObjectPattern') ||
(key === 'key' && !parent.computed && parent.parent.type === 'ObjectPattern') ||
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you come up with a test case demonstrating what this is supposed to fix?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added tests

(key === 'left' && parent.type === 'AssignmentPattern') ||
(key === 'elements' && parent.type === 'ArrayPattern') ||
(key === 'value' &&
Expand Down