Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use @sapphire/shapeshift #421

Open
S222em opened this issue Apr 20, 2022 · 2 comments
Open

Use @sapphire/shapeshift #421

S222em opened this issue Apr 20, 2022 · 2 comments
Assignees
Milestone

Comments

@S222em
Copy link
Collaborator

S222em commented Apr 20, 2022

Feature

@sapphire/shapeshift should be used instead of zod.

Shapeshift is a much faster validation library than zod, I did see the benchmarks somewhere but I can't find it anymore.

The API is mostly similar so it won't be a lot of work.

https://github.com/sapphiredev/shapeshift

Ideal solution or implementation

Switch from zod to @sapphire/shapeshift

Alternative solutions or implementations

Don't

Other context

No response

@S222em S222em added this to the v9.2.0 milestone Apr 20, 2022
@bucket-bot
Copy link

bucket-bot bot commented Apr 20, 2022

Hey @S222em! Thank you for opening the issue. However, we are not machines, so it may take us a while to get back to you.

But if you don't want to report a problem, please contact our discord server

@S222em S222em self-assigned this Apr 20, 2022
@xhyrom
Copy link
Member

xhyrom commented Apr 20, 2022

👍👍👍

@S222em S222em linked a pull request Apr 26, 2022 that will close this issue
@S222em S222em modified the milestones: v9.2.0, v10 Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants