Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use @sapphire/shapeshift #427

Closed
wants to merge 2 commits into from
Closed

refactor: use @sapphire/shapeshift #427

wants to merge 2 commits into from

Conversation

S222em
Copy link
Collaborator

@S222em S222em commented Apr 26, 2022

Please describe the changes this PR makes and why it should be merged:
#421

Status and versioning classification:
None

@S222em S222em added this to the v10 milestone Apr 26, 2022
@S222em S222em self-assigned this Apr 26, 2022
@github-actions github-actions bot requested review from nexpid and xhyrom April 26, 2022 08:35
@S222em S222em marked this pull request as draft April 26, 2022 08:37
@S222em S222em linked an issue Apr 26, 2022 that may be closed by this pull request
@xhyrom
Copy link
Member

xhyrom commented Apr 28, 2022

v10?

@S222em
Copy link
Collaborator Author

S222em commented Apr 29, 2022

v10?

I still need to fix some things, probably an issue with shapeshift, so it probably wont be done in time for v9.2

@S222em S222em modified the milestones: v10, v9.2.0 May 1, 2022
@S222em
Copy link
Collaborator Author

S222em commented May 1, 2022

I will take another look at the issue I have tomorrow and then decide if it will make v9.2.0, I think the issue I have currently is a issue with shapeshift, so it needs to get fixed and released on their side first. (Did not get to it, will do it soon)

@github-actions github-actions bot added the chore label May 13, 2022
@S222em
Copy link
Collaborator Author

S222em commented May 13, 2022

Okay, so I finally looked at this. It seems like AutoDeferType is not actually exported from GClient.ts for some reason. It is listed correctly in the compiled code, but sadly it's still undefined, which throws an error. I am not sure how to magically make AutoDeferType be there so this might take a while to figure out.

@S222em S222em closed this by deleting the head repository Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use @sapphire/shapeshift
2 participants