-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typing: timestepper module #372
Merged
skim0119
merged 16 commits into
GazzolaLab:update/mypy
from
skim0119:typing/timestepper
Apr 30, 2024
Merged
Typing: timestepper module #372
skim0119
merged 16 commits into
GazzolaLab:update/mypy
from
skim0119:typing/timestepper
Apr 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skim0119
added
enhancement
New feature or request
prio:low
Priority level: low
github_actions
Pull requests that update GitHub Actions code
labels
Apr 29, 2024
armantekinalp
approved these changes
Apr 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM nice work @skim0119
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
github_actions
Pull requests that update GitHub Actions code
prio:low
Priority level: low
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type-hinting
timestepper
moduleNew Protocols
elastica/system/protocol.py
: generic protocol for allSystemType
SymplecticSystemProtocol
andExplicitSystemProtocol
elastica/timestepper/protocol.py
:StepperProtocol
StatefulStepperProtocol
MethodCollectorProtocol
for class that generates operators.MemoryProtocol
for state representation of timesteppers. (unused)Refactoring
__init__
,args
, andkwargs
are removed.SymplecticStepperTag
andExplicitStepperTag
are now intag.py
elastica.timestepper.tag.tag
.MockRod
andMockRigidBody
was created usingTypeAlias
, which is not an intended usage. It is refactored to import original base classes.Minor changes
isinstance
is safer type-comparison instead oftype(...) == type(...)
float
types tonp.floating
FLOAT: TypeAlias = float | np.floating
.