Add support for standard list type hints #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ge0rg3
requested changes
Jul 11, 2024
|
I think to resolve current conflicts we can just take this branch version as source of truth? |
smt5541
force-pushed
the
dev/smt5541/typing_list_deprecated
branch
from
5779749 to
3b43953
Compare
smt5541
force-pushed
the
dev/smt5541/typing_list_deprecated
branch
from
3b43953 to
e425b8c
Compare
Eh, mostly - some indentations introduced in other PRs made it a little messier, but that's all set now |
Ge0rg3
approved these changes
Jul 13, 2024
|
Btw love the added pypi classifiers on this, should help with project visibility 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠 Changes being made
Give examples of the changes you've made in this pull request. Include an itemized list if you can.
ValidateParameters#__call__andValidateParameters#validateto supportlistalongside the existing support fortyping.Listsetup.pyto add supported version information and additional PyPI classifiers🧠 Rationale behind the change
Why did you choose to make these changes?
Reading through the
typingdocumentation, I noticed thattyping.Listwas deprecated as of Python 3.9. Since this library currently targets Python 3.9 at a minimum per some of its dependencies, it seems this would be a fitting changeDoes this pull request resolve any open issues?
Closes #48
Were there any trade-offs you had to consider?
I had to ensure that our minimum supported Python version would not be changed by implementing this support. Our dependencies pin us to a minimum of Python 3.9, so it seems we remain at that level.
🧪 Testing
Have tests been added or updated for the changes introduced in this pull request?
Are the changes backwards compatible?
If the changes aren't backwards compatible, what other options were explored?
✨ Quality check
Are your changes free of any erroneous print statements, debuggers or other leftover code?
Has the README been updated to reflect the changes introduced (if applicable)?
💬 Additional comments
Feel free to add any further information below
Depends on #45