Correctly compute contour length for wrapped contours #6102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
COntours split across periodic boundaries will have jumps across the map. These are not drawn, but the code used them in computing the length which affects how many ticks are set. This corrects the contour length calculations.
|
@PaulWessel What script do you use for the figure? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contours split across periodic boundaries will have jumps across the map. These are not drawn, but the code used them in computing the length which affects how many ticks are set. This corrects the contour length calculations. Here is an example of before (see the lower right side):
This is after the fix:
No tests were affected since we rarely place lots of ticks on contours.