Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix macos/ARM/clang compile errors #297

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

fix macos/ARM/clang compile errors #297

wants to merge 5 commits into from

Conversation

congyu711
Copy link

This PR fixes compile errors on ARM macos with clang, see #295

NOTE: this PR removes #include <immintrin.h> in file external/PackedCSparse/FloatArray.h

@TolisChal TolisChal force-pushed the develop branch 4 times, most recently from 906e119 to f1abc36 Compare July 7, 2024 02:25
@vfisikop
Copy link
Contributor

vfisikop commented Feb 2, 2025

Slipped under my radar, sorry, I will review ASAP.

vfisikop
vfisikop reviewed Feb 2, 2025
View reviewed changes
Copy link
Contributor

@vfisikop vfisikop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please update your branch with current develop because now reviewing is very difficult.

Also it should be better to include <immintrin.h> conditionally if the architecture is not ARM instead of completely removing it.

@congyu711
Copy link
Author

Thanks for your review. The branch has been updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vfisikop vfisikop vfisikop left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@congyu711 @vfisikop