[kde,win32] initDimensions() functions: Don't store the string tempor…

…arily. Inline the formatDimensions() call into the initString() call. This doesn't affect the code size in either debug or release builds.
GerbilSoft · Feb 1, 2025 · f431875 · f431875
1 parent ff23009
commit f431875
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/src/kde/RomDataView.cpp b/src/kde/RomDataView.cpp
@@ -732,8 +732,7 @@ QLabel *RomDataViewPrivate::initDimensions(QLabel *lblDesc,
 {
 	// Dimensions
 	const int *const dimensions = field.data.dimensions;
-	const QString str = formatDimensions(dimensions);
-	return initString(lblDesc, field, str);
+	return initString(lblDesc, field, formatDimensions(dimensions));
 }
 
 /**

diff --git a/src/win32/RP_ShellPropSheetExt.cpp b/src/win32/RP_ShellPropSheetExt.cpp
@@ -1324,8 +1324,8 @@ int RP_ShellPropSheetExt_Private::initDimensions(_In_ HWND hWndTab,
 {
 	// TODO: 'x' or '×'? Using 'x' for now.
 	const int *const dimensions = field.data.dimensions;
-	const tstring tstr = formatDimensions(dimensions);
-	return initString(hWndTab, pt_start, size, field, fieldIdx, tstr.c_str());
+	return initString(hWndTab, pt_start, size, field, fieldIdx,
+		formatDimensions(dimensions).c_str());
 }
 
 /**