fix: multiple mentions render in message text #2286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
santhoshvai
approved these changes
Nov 6, 2023
Merged
khushal87
added a commit
that referenced
this pull request
Nov 6, 2023
* feat: apply theme to SendButton internal icons (#2280) * fix: crash when opening null url (#2134) * fix: crash when opening null url * fix: only check url if type is video previous if would fail the validation for non-video attachments --------- Co-authored-by: Arthur Geron <[email protected]> * feat: upgrade axios to v1 (#2281) * fix: multiple mentions render in message text (#2286) * chore: replace last_message_at with last_updated (#2282) * chore: replace last_message_at with last_updated * fix: keep the same order as before * fix(expo): do not show reconnecting status while showing gallery --------- Co-authored-by: Khushal Agarwal <[email protected]> Co-authored-by: Arthur Geron <[email protected]> Co-authored-by: Arthur Geron <[email protected]> Co-authored-by: Vishal Narkhede <[email protected]>
Merged
|
🎉 This PR is included in version 5.20.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Fixes #2283
The PR also updates the dependencies of Axios in packages and sample apps after #2281
🛠 Implementation details
The regex is used in individual usernames rather than the accumulator of the reduce method.
🎨 UI Changes
Before:
After:
iOS
Android
🧪 Testing
☑️ Checklist
developbranch