[Port] Add Time Transfer Panel From Upstream #35
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!-- This is a semi-strict format, you can add/remove sections as needed but the order/format should be kept the same Remove these comments before submitting --> # Description This adds the Time Transfer Panel that Goobstation uses. This panel enables Admins to do Time Transfers without commands and makes their lives easier. This immediately has access to all playtime trackers and allows an Admin to Add Time and/or Set Time (overwriting the previous time) for any job role. It also enables extra strings since I ported from Wizden upstream as well, which can be seen in the commit history. A thing of note when testing this and using it in a server: the times **DO NOT UPDATE** for Client until your **RELOG**. This is how it works on Goobstation as well. The time adding process is faster and will be easier tool. This is tied to the AdminFlags.Admin so it can be customized on a per-server basis if a custom flag is added. --- # TODO - [x] Port Upstream Role Define. - [x] Port string extras for playtime commands. - [x] Port Time Transfer Panel - [x] Remove Overall (it just doesn't work on Goob either). --- <details><summary><h1>Media</h1></summary> <p>          </p> </details> --- # Changelog :cl: ADMIN: - add: Add Time Transfer Panel --------- Co-authored-by: BombasterDS <[email protected]> Co-authored-by: Leon Friedrich <[email protected]> Co-authored-by: flyingkarii <[email protected]>
github-actions
bot
added
Changes: YML
Changes: C#
Changes: Localization
Changes: UI
labels
|
I did not port the upstream changelog for this, as it has content not included in this merge. It should be ported when the time comes. For now, since this is an ADMIN changelog anyway, I don't think it matters. |
I don't want merge conflicts when merging upstream. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds the Time Transfer Panel that Goobstation uses. This panel enables Admins to do Time Transfers without commands and makes their lives easier. This immediately has access to all playtime trackers and allows an Admin to Add Time and/or Set Time (overwriting the previous time) for any job role. It also enables extra strings since I ported from Wizden upstream as well, which can be seen in the commit history.
A thing of note when testing this and using it in a server: the times DO NOT UPDATE for Client until your RELOG. This is how it works on Goobstation as well. The time adding process is faster and will be easier tool.
This is tied to the AdminFlags.Admin so it can be customized on a per-server basis if a custom flag is added.
TODO
Media