Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Erm.... No More Foreigner Trait Head Roles!!!!! #40

Closed
wants to merge 32 commits into from

Conversation

SixplyDev
Copy link
Contributor

@SixplyDev SixplyDev commented Jan 11, 2025

Description

This PR prevents heads of staff and security members from having foreigner traits, muted trait, blindness trait, and pacifist trait (only HoS & Cap cannot be pacifist). These traits are major disabilities and actively detrimental to their departments & the rest of command staff if they have them. These traits make them unable to clearly and effectively communicate or render them unable to do a critical part of their jobs in the case of pacifist and muted.


TODO

  • Security Department can no longer have pacifist, muted, blind, brittle bone disease, or foreigner traits.
  • Head of Security can no longer have pacifist, muted, blind, brittle bone disease, or foreigner traits.
  • Heads of staff can no longer have muted, blind, or foreigner traits.
  • The Captain can no longer have pacifist, muted, blind, brittle bone disease, or foreigner traits.
  • Head of Personnel can no longer have muted, blind, or foreigner traits.

Changelog

🆑 ShirouAjisai

  • tweak: Security Department can no longer have pacifist, muted, blind, brittle bone disease, or foreigner traits.
  • tweak: Head of Security can no longer have pacifist, muted, blind, brittle bone disease, or foreigner traits.
  • tweak: Heads of staff can no longer have muted, blind, or foreigner traits.
  • tweak: The Captain can no longer have pacifist, muted, blind, brittle bone disease, or foreigner traits.
  • tweak: The Head of Personnel can no longer have muted, blind, or foreigner traits.

HoS can no longer be a foreigner
HoS can no longer be mute
Detective can no longer be mute or have foreigner traits
Cadets can no longer be mute or foreigner trait
HoS can no longer be blind or a pacifist
Detective can no longer be blind or a pacifist
Cadets can no longer be blind or pacifists
Secoffs can no longer be muted, blind, pacifists, or foreigner traits
Senior officers can no longer be blind, mute, pacifists, or have foreigner traits
Wardens can no longer be mute, blind, pacifists, or have foreigner traits
Research Director can no longer be mute, blind, a pacifist, or have foreigner traits
Chief Medical Officer can no longer be mute, blind, a pacifist, or have foreigner traits
Chief Engineer can no longer be mute, blind, a pacifist, or have foreigner traits
Head of Personnel can no longer be mute, blind, a pacifist, or have foreigner traits
Captain can no longer be mute, blind, a pacifist, or have foreigner traits
@GoobBot GoobBot changed the title erm.... no more foreigner trait head roles!!!!! Erm.... No More Foreigner Trait Head Roles!!!!! Jan 11, 2025
Forgot to do QM, oopsies
Copy link
Contributor

@CerberusWolfie CerberusWolfie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pacifism should not exist on select Head of Staff. They do not necessarily need to defend themselves with lethality. Captain and HoS make sense.

Copy link
Contributor

@CerberusWolfie CerberusWolfie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an issue, this should be fixed.

Copy link
Contributor

@CerberusWolfie CerberusWolfie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security is fine, and if you address the Head of Security typo, then the entire Security department would be fine to push.

Fixed typo teehee oops
QM can be pacifist again :(
HoP can be pacifist again :P
CE can be pacifist again :)
CMO can be pacifist again :D
Mystagogue can be pacifist again D:
@CerberusWolfie
Copy link
Contributor

You can mark the security typo as resolved.

@SixplyDev
Copy link
Contributor Author

All issues resolved

@SixplyDev
Copy link
Contributor Author

Description updated to inclue new changes

Copy link
Contributor

@CerberusWolfie CerberusWolfie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would be fine with limiting Foreigner in Command Positions. I don't particularly like it, since batteries exist.

Copy link
Contributor

@CerberusWolfie CerberusWolfie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take away Foreigner and Foreigner Light requirements. I don't see these as impeding anything.

@SixplyDev
Copy link
Contributor Author

I'm standing firm on my decision to keep foreigner & foreigner light there. They impede effective communication with your team which is essential. Additionally, it makes no sense for a company like Nanotrasen to hire managers who can't even speak the common language of the company or the majority of its employees.

Corpsman can no longer be mute, blind, a pacifist, or have foreigner traits
Copy link
Contributor

@CerberusWolfie CerberusWolfie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like Foreigner being disabled, same as above comments.

Corpsman can no longer have brittle bone disease (crit at 50 damage)
Head of Security can no longer have brittle bone disease (crit at 50 damage)
Detective is no longer able to have brittle bone disease (crit at 50 damage)
Cadets can no longer have brittle bone disease (crit at 50 damage)
Officers can no longer have brittle bone disease (crit at 50 damage)
Senior Officers can no longer have brittle bone disease (crit at 50 damage)
Warden can no longer have brittle bone disease (crit at 50 damage)
Captain can no longer have brittle bone disease (crit at 50 damage)
@SixplyDev
Copy link
Contributor Author

I don't like Foreigner being disabled, same as above comments.

Respectfully, security is the one job section aside from command where not having foreigner is an absolute MUST

@CerberusWolfie
Copy link
Contributor

I don't like Foreigner being disabled, same as above comments.

Respectfully, security is the one job section aside from command where not having foreigner is an absolute MUST

I don't agree. Security having a translator is not inherently a bad concept. The only downside to translators is losing power during critical moments, but a good player would be able to prepare for this.

@SixplyDev
Copy link
Contributor Author

I don't like Foreigner being disabled, same as above comments.

Respectfully, security is the one job section aside from command where not having foreigner is an absolute MUST

I don't agree. Security having a translator is not inherently a bad concept. The only downside to translators is losing power during critical moments, but a good player would be able to prepare for this.

Security should be able to effectively do their job without the assistance of technology and in any environment. Once we have shoves fully added in when we merge with upstream, it'll be a reality.

@CerberusWolfie
Copy link
Contributor

I don't like Foreigner being disabled, same as above comments.

Respectfully, security is the one job section aside from command where not having foreigner is an absolute MUST

I don't agree. Security having a translator is not inherently a bad concept. The only downside to translators is losing power during critical moments, but a good player would be able to prepare for this.

Security should be able to effectively do their job without the assistance of technology and in any environment. Once we have shoves fully added in when we merge with upstream, it'll be a reality.

Except you don't need the translator in your hand to use it. So this point is pretty null.

@SixplyDev
Copy link
Contributor Author

I don't like Foreigner being disabled, same as above comments.

Respectfully, security is the one job section aside from command where not having foreigner is an absolute MUST

I don't agree. Security having a translator is not inherently a bad concept. The only downside to translators is losing power during critical moments, but a good player would be able to prepare for this.

Security should be able to effectively do their job without the assistance of technology and in any environment. Once we have shoves fully added in when we merge with upstream, it'll be a reality.

Except you don't need the translator in your hand to use it. So this point is pretty null.

The point was that you should be able to do your job effectively without the use of technology. Communicating clearly and effectively is part of your job as a security officer

Copy link
Contributor

@CerberusWolfie CerberusWolfie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've talked to some others and gotten more information regarding this. I'll accept Foreigner being removed from Command and Security. NanoTrasen would not care and would not promote people to that position.

@Aidenkrz Aidenkrz deleted the branch Goob-Station:master January 12, 2025 03:42
@Aidenkrz Aidenkrz closed this Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants