Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update server and server core publish workflows for byol #2426

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jjerger
Copy link
Contributor

@jjerger jjerger commented Jan 10, 2025

Add support for byol environment publishing recently added to concourse

Add support for byol environment publishing recently added to concourse
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jjerger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Needed to avoid image name conflict on byol publishes
@jjerger
Copy link
Contributor Author

jjerger commented Jan 30, 2025

/assign bkatyl

@bkatyl
Copy link
Contributor

bkatyl commented Jan 31, 2025

Has this been tested? I'm not sure it's going to fix the error as it was relating to the source file in GCS.

@jjerger
Copy link
Contributor Author

jjerger commented Feb 3, 2025

Has this been tested? I'm not sure it's going to fix the error as it was relating to the source file in GCS.

The source file issue was because the name of the prefix set in the publish file. See:
https://github.com/GoogleCloudPlatform/compute-image-tools/blob/master/daisy_workflows/build-publish/windows/windows-server-2025-dc-uefi.publish.json#L39

By keeping the prefix the same but changing the destination family name the source file will have the correct name. The caveat to this is that the image names for the byol and non-byol images will be identical but with different image families. Since the publish project is different, there won't be a name collision.

As for testing this- I'm not sure of a good way to do so since it relies on the Concourse method of building the image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants