This repository has been archived by the owner on Sep 15, 2022. It is now read-only.
Update upstream docker/docker-registry repository #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bshi I wonder if we should vendor the patch instead and apply it on build. |
|
I'm agnostic to the approach. Where and how in the build/development process do you envision the patch being applied? |
|
@bshi in the Dockerfile, just add a |
|
@proppy See updated PR. Had to add ca-certificates for curl over https (and included a cleanup step to save a significant chunk of space in that image layer since the layer would require a rebuild anyway). |
Updates docker-registry from 0.8 to 0.9 and vendors a patch (slated to be released in 1.0) to address issue #22.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to 0.9 + the merge of the patch that addresses #22
@proppy can I convince you to upgrade the upstream package to address the linear scan issue? We'd rather pull from the official google docker images rather than baking our own. The patch that fixes #22 was just accepted in docker/docker-repository today as the first commit after the 0.9 release.