This repository has been archived by the owner on Sep 2, 2022. It is now read-only.
Add flinkPropertiesSecret for supporting secret properties #449
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Add possibilities for mounting secret properties from
Secret
.Resolves #383
Implementation strategy
As @shashken described at #383 (comment),
Use
flinkPropertiesSecret
option in CRD and mount the entire properties into a Secret like @functicons suggested.flinkPropertiesSecret
set,ConfigMap
to config directory since mounting specific file fromemptyDir
is not possible./opt/flink/conf/flink-conf.yaml
readonly
mounted to main containers as same as currentConfigMap
implementation.ConfigMap
as config volume like as-is.Limitations
ConfigMap
updates without restarting the pod