Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import projects in sequence to avoid failure to recognize dependent project #3135

Merged
merged 1 commit into from
Jun 6, 2018

Conversation

chanseokoh
Copy link
Contributor

Fixes #1798 (#1798 (comment)).

I've split the projects into two zips: sox-server.zip and sox-shared.zip.

@codecov
Copy link

codecov bot commented Jun 5, 2018

Codecov Report

Merging #3135 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3135      +/-   ##
============================================
+ Coverage     69.25%   69.28%   +0.03%     
- Complexity     2834     2837       +3     
============================================
  Files           371      371              
  Lines         13194    13194              
  Branches       1562     1562              
============================================
+ Hits           9137     9141       +4     
+ Misses         3418     3416       -2     
+ Partials        639      637       -2
Impacted Files Coverage Δ Complexity Δ
.../tools/eclipse/test/util/project/ProjectUtils.java 67.23% <0%> (-1.7%) 39% <0%> (-1%)
...ow/ui/preferences/RunOptionsDefaultsComponent.java 78.57% <0%> (+0.62%) 60% <0%> (+2%) ⬆️
...e/cloud/tools/eclipse/util/jobs/FuturisticJob.java 80% <0%> (+1.25%) 29% <0%> (+1%) ⬆️
.../facets/ui/navigator/AppEngineContentProvider.java 76.56% <0%> (+3.12%) 28% <0%> (ø) ⬇️
...ibraries/LibraryClasspathContainerResolverJob.java 92.3% <0%> (+15.38%) 3% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8057fcb...bca2993. Read the comment docs.

@chanseokoh
Copy link
Contributor Author

I think this small change is simple and does its job. Any other simpler alternative?

Copy link
Member

@briandealwis briandealwis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We won't know if it works until it doesn't :-( The change doesn't hurt though, so let's do it.

serverModule = ServerUtil.getModule(serverProject);
sharedModule = ServerUtil.getModule(serverProject);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh, that's a good catch!

@chanseokoh
Copy link
Contributor Author

Fingers crossed. The error was specifically

"sox-server is missing required Java project: sox-shared",

so the hope is that Eclipse will not botch if sox-shared exists far before when trying to import sox-server.

@chanseokoh chanseokoh merged commit 0a9fe0f into master Jun 6, 2018
@chanseokoh chanseokoh deleted the i1798-open-projects-in-seq branch June 6, 2018 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants