Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: outputs which kube-context is being used for skaffold dev #8587

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

riyamittal009
Copy link

Fixes: #6861

Description
Outputs kube context on skaffold dev, which originally could only be seen with -v info flag following the command.

User facing changes
First line of output of skaffold dev is "Using kubectl context: " + kube context name.
Before:
Before

After:
After

@google-cla
Copy link

google-cla bot commented Mar 26, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented Mar 26, 2023

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@riyamittal009 riyamittal009 changed the title Outputs which kube-context is being used for skaffold dev Outputs which kube-context is being used for skaffold dev Mar 26, 2023
@ericzzzzzzz
Copy link
Contributor

Hi @riyamittal009 , skaffold released a new schema since pr is created, this causes ci fail. Could you rebase your pr?

@renzodavid9
Copy link
Contributor

Hey @riyamittal009, just a friendly ping about previous comment. Thanks a lot! 😄

@riyamittal009
Copy link
Author

Just rebased! :)

@ericzzzzzzz ericzzzzzzz changed the title Outputs which kube-context is being used for skaffold dev chore: outputs which kube-context is being used for skaffold dev Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skaffold should output which kube-context + cluster is being used
3 participants