Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not reserve space for an icon in settings list #395

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

t895
Copy link
Contributor

@t895 t895 commented Oct 21, 2024

There is no icon in this list so it does not need the reserved space

Before:
image

After:
image

There is no icon in this list so it does not need the reserved space
@muhomorr
Copy link
Member

muhomorr commented Jan 5, 2025

This is the intended behavior according to https://issuetracker.google.com/issues/119882818. Google's apps (e.g. Contacts) have this extra margin too.

@muhomorr
Copy link
Member

muhomorr commented Jan 5, 2025

Many other Google apps don't have the extra margin, not clear if they use the androidx preference library.

@muhomorr
Copy link
Member

muhomorr commented Jan 5, 2025

Also, default release channel setting doesn't have the app:iconSpaceReserved attribute. Adding it manually to all preferences seems wrong.

@t895
Copy link
Contributor Author

t895 commented Jan 5, 2025

This is the intended behavior according to https://issuetracker.google.com/issues/119882818. Google's apps (e.g. Contacts) have this extra margin too.

I know they have this extra margin in Google apps, but that doesn't take away from it being a very outdated look. Although I guess this highlights the larger issue of how androidx preference doesn't use up-to-date material 3 components.

Are you thinking that we just keep this as-is until we can replace it with a more modern look?

Also, default release channel setting doesn't have the app:iconSpaceReserved attribute. Adding it manually to all preferences seems wrong.

That's fair, I could see if I could make this a default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants