Enhance forms and other improvements #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quh4gko8
reviewed
Nov 16, 2023
static/monitoring.js
Outdated
| if (createFormContent.contains(this.parentElement)) { | ||
| createFormContent.hidden = true; | ||
| } | ||
| else { |
There was a problem hiding this comment.
Code style nit:
...
} else {
...
is preferred, as also used in other portion of this js file
|
The css seems broken for Desktop Mode at Chromium-based browsers in Android. The |
|
This should fix the issue. |
quh4gko8
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current home page
Proposed home page
Current home page on mobile
Proposed home page on mobile
Current account creation form
Proposed account creation form
When additional information unfolded
Current login form
Proposed login form
Current device pairing page
Proposed device pairing page
Other forms on the website will look similar as well.
Additional ideas or opinions are welcome.