Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move action links to top #1944

Closed
wants to merge 7 commits into from
Closed

Conversation

zackkatz
Copy link
Member

@zackkatz zackkatz commented Oct 29, 2023

Resolves #1814 while also doing some simplifying of things.

  • Instead of adding Edit Link to includes/fields in 03277d1, instead move to includes/extensions/edit-entry/, like we did with the Delete Entry link field
  • Review line 877–883 of class-admin-views.php—I wrote this on a plane. Apparently my best coding happens on the ground!

The pseudo-field thing using filters (the add_default_field() method) was always a bad idea.
This will be positioned at the top of the field picker, as requested in #1814.

There should be some styling (perhaps simply a divider) to distinguish between these featured fields and the rest.
Now that we're inserting the featured fields in `GravityView_Admin_Views::get_available_fields()`, we no longer need to add them using this method.
@zackkatz zackkatz requested a review from mrcasual October 29, 2023 00:20
@mrcasual
Copy link
Collaborator

mrcasual commented Nov 2, 2023

Closing in favor of #1948 where these changes were merged. One outstanding action item was moved to #1949.

@mrcasual mrcasual closed this Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move the Link to Edit Entry and Delete Entry up inside the field picker modal
2 participants