Fixed Custom Post Fields acting as File Uploads on Entry Edit Page #1971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! It works 👏👏👏✅❤️ |
doekenorg
force-pushed
the
issue/1317-cant-edit-a-post-custom-field-set-up-as-a-file-upload-field
branch
from
d90f8cf to
6c8875a
Compare
…set-up-as-a-file-upload-field
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR Closes #1317
The type checking for upload fields excluded custom fields by default by not using
get_input_type(). That already provides the right type for the custom post fields.And because files are not provides by an input field during updating a different field, I skip the
get_value_save_entry()method, as it has no value, and removes the image completely.