Add notification event for deleting entries (GK only) #1972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@doekenorg What do you mean "removal of entry in gravity forms"? If trash/delete, I believe this item is resolved. |
@zackkatz yeah sorry, that was resolved indeed 👍 |
zackkatz
approved these changes
Jan 22, 2024
zackkatz
deleted the
feature/1819-trigger-notification-when-entry-is-deleted
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #1819
I moved the notification logic to a separate service class. To avoid issues when people switch mode from
deletetotrashthe hook listens to both.Added unit tests to confirm inner workings.
Todo:
@zackkatz Should that be a separate event? It feels kind of weird triggering the
GravityView - Entry is deletedevent when you delete an entry in Gravity Forms.