Version 2.19.6 #1984
Merged
Version 2.19.6 #1984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [tough-cookie](https://github.com/salesforce/tough-cookie) from 4.1.2 to 4.1.3. - [Release notes](https://github.com/salesforce/tough-cookie/releases) - [Changelog](https://github.com/salesforce/tough-cookie/blob/master/CHANGELOG.md) - [Commits](salesforce/tough-cookie@v4.1.2...v4.1.3) --- updated-dependencies: - dependency-name: tough-cookie dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [word-wrap](https://github.com/jonschlinkert/word-wrap) from 1.2.3 to 1.2.4. - [Release notes](https://github.com/jonschlinkert/word-wrap/releases) - [Commits](jonschlinkert/word-wrap@1.2.3...1.2.4) --- updated-dependencies: - dependency-name: word-wrap dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
See https://stackoverflow.com/a/49449955/480856 I haven't tested this yet.
See https://stackoverflow.com/a/49449955/480856 I confirmed that `$( 'body' )` listeners will still work when triggers are sent to `$( document.body )`, so this is back-compatible.
…1870) Bumps [tough-cookie](https://github.com/salesforce/tough-cookie) from 4.1.2 to 4.1.3. Security fix for Prototype Pollution discovery in <a href="https://redirect.github.com/salesforce/tough-cookie/issues/282">#282</a>.
Bumps [postcss](https://github.com/postcss/postcss) from 8.4.5 to 8.4.31. - [Release notes](https://github.com/postcss/postcss/releases) - [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md) - [Commits](postcss/postcss@8.4.5...8.4.31) --- updated-dependencies: - dependency-name: postcss dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [postcss](https://github.com/postcss/postcss) from 8.4.21 to 8.4.32. - [Release notes](https://github.com/postcss/postcss/releases) - [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md) - [Commits](postcss/postcss@8.4.21...8.4.32) --- updated-dependencies: - dependency-name: postcss dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [word-wrap](https://github.com/jonschlinkert/word-wrap) from 1.2.3 to 1.2.4. Changelog: https://github.com/jonschlinkert/word-wrap/releases
Bumps [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse) from 7.20.12 to 7.23.6. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.23.6/packages/babel-traverse) --- updated-dependencies: - dependency-name: "@babel/traverse" dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [postcss](https://github.com/postcss/postcss) from 8.4.5 to 8.4.31. Changelog: https://github.com/postcss/postcss/releases
…berg (#1963) Bumps [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse) from 7.20.12 to 7.23.6. Changelog: https://github.com/babel/babel/releases
Bumps [postcss](https://github.com/postcss/postcss) from 8.4.21 to 8.4.32. Changelog: https://github.com/postcss/postcss/releases
First, handle comments that have punctuation marks: ``` @(filter|action) `(.*)` (.*?)([!?])(\n\s+\*) ``` Replace with: ``` $3$4$5 ``` Then handle comments that do or don't end with periods: ``` @(filter|action) `(.*)` (.*?)([.]?)(\n\s+\*) ``` Replace with: ``` $3.$5 ```
This PR Closes #1906. There was no strict checking, so `false` was evaluated as `0` (`+ 1 = 1`).
I wasn't able to install using `npm i` because the node-sass package failed at ``` npm WARN deprecated [email protected]: This SVGO version is no longer supported. Upgrade to v2.x.x. ```
I fixed all (most?) issues that could be resolved automatically. Bringing the entire codebase to 100% compliance will take quite an effort, but it can be done incrementally as we commit changes. To prevent `phpcs` from running during the pre-commit stage, use the `--no-verify` flag with the `git commit` command. Make sure to run `npm i && composer install`.
This PR closes #1819 I moved the notification logic to a separate service class. To avoid issues when people switch mode from `delete` to `trash` the hook listens to both. Added unit tests to confirm inner workings. Todo: - [x] Trigger event on a removal of entry in gravity forms @zackkatz Should that be a separate event? It feels kind of weird triggering the `GravityView - Entry is deleted` event when you delete an entry in Gravity Forms.
…set-up-as-a-file-upload-field
…1971) This PR Closes #1317 The type checking for upload fields excluded custom fields by default by not using `get_input_type()`. That already provides the right type for the custom post fields. And because files are not provides by an input field during updating a different field, I skip the `get_value_save_entry()` method, as it has no value, and removes the image completely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
= 2.19.6 on February 7, 2024 =
This update introduces the ability to send notifications using Gravity Forms when an entry is deleted, improves sorting and survey field ratings, and updates key components for better performance and compatibility.
🚀 Added
🔧 Updated
🐛 Fixed
Developer Updates:
GravityView_Notificationsclass as a wrapper for Gravity Forms notifications.\GV\Viewobject as a second parameter for thegravityview/search-all-split-wordsandgravityview/search-trim-inputfilters.$( document.body )instead of$('body')for speed improvements.