Fix recursion in ACF fields with GravityView shortcodes #1998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zackkatz
deleted the
issue/1812-the-gravityview-shortcode-doesnt-work-when-embedded-inside-an-acf-wysiwyg-block
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adresses #1812.
It looks like a recursion is going on when trying to retrieve the meta fields for a post. It used the
get_field_objects()method of ACF. Apparently they are right when they say:So I've replaced it with half the internal method, retrieving the meta keys for ACF only, and microcaching the result.
This fixes the recursion for me, and I'm able to show the view when rendering
the_field('content');.