New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing tests #2153

Merged

mrcasual merged 1 commit into develop from issue/2152-failing-tests-in-test_format_date-for-human-modifier

Sep 26, 2024

Collaborator

omarkasem commented Sep 26, 2024 •

edited by floatytheastronaut

Loading

Fixes Failing tests in test_format_date for human modifier #2152
Fixed tests that might fail because of timezones
The issue was that i was using GFCommon::get_local_timestamp to convert the timestamp to the local one according to current site timezone
Then i was comparing it using human_time_diff function which uses time() as the second argument by default which is just the regular timestamp not adjusted for the current site timezone

💾 Build file (7ad6529).


          Fix failing tests

7ad6529

omarkasem linked an issue

that may be closed by this pull request

Failing tests in test_format_date for human modifier #2152

Closed

omarkasem self-assigned this

omarkasem requested a review from mrcasual

September 26, 2024 08:44

mrcasual assigned mrcasual and unassigned omarkasem

mrcasual merged commit 8263fd3 into develop

2 checks passed

mrcasual deleted the issue/2152-failing-tests-in-test_format_date-for-human-modifier branch

September 26, 2024 15:13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet