Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds support for array fields as in sub fields #2187

Merged
merged 6 commits into from
Dec 19, 2024
Merged

Adds support for array fields as in sub fields #2187

merged 6 commits into from
Dec 19, 2024

Conversation

omarkasem
Copy link
Collaborator

@omarkasem omarkasem commented Oct 31, 2024 •
edited by floatytheastronaut
Loading

@omarkasem omarkasem linked an issue Oct 31, 2024 that may be closed by this pull request
Add the ability to support the :format modifier for sub fields #2186
Closed
@omarkasem omarkasem self-assigned this Oct 31, 2024
@omarkasem omarkasem requested a review from mrcasual October 31, 2024 02:22
@mrcasual
Copy link
Collaborator

mrcasual commented Oct 31, 2024 •
edited
Loading

@Mwalek @rafaehlers, please test.

@mrcasual mrcasual assigned mrcasual and Mwalek and unassigned omarkasem and mrcasual Oct 31, 2024
@mrcasual mrcasual assigned rafaehlers and unassigned Mwalek Nov 7, 2024
@rafaehlers
Copy link
Contributor

I'm on it: https://github.com/GravityKit/Event-Field/pull/71#issuecomment-2471246347

@rafaehlers
Copy link
Contributor

This works now: https://github.com/GravityKit/Event-Field/pull/71#issuecomment-2504716127

@mrcasual mrcasual merged commit 473efbb into develop Dec 19, 2024
1 check passed
@mrcasual mrcasual deleted the issue/2186-add-the-ability-to-support-the-format-modifier-for-sub-fields branch December 19, 2024 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrcasual mrcasual Awaiting requested review from mrcasual

Assignees

@rafaehlers rafaehlers

@mrcasual mrcasual

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add the ability to support the :format modifier for sub fields
4 participants
@omarkasem @mrcasual @rafaehlers @Mwalek