Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Fix get entries query #2199

Closed
wants to merge 1 commit into from

Conversation

zahardev
Copy link
Contributor

@zahardev zahardev commented Nov 11, 2024

Resolves #2198

@zahardev zahardev changed the title Fix get entries query [WIP] Fix get entries query Nov 11, 2024
@zackkatz
Copy link
Member

@zahardev Thanks for the PR!

Some of the unit tests are failing. Can you please review those:


1) GravityView_Joins_Test::test_joins_with_approves
Failed asserting that actual size 1 matches expected size 0.

*********************/tests/unit-tests/GravityView_Joins_Test.php:375

2) GravityView_Joins_Test::test_joins_joined_status
Failed asserting that actual size 2 matches expected size 1.

*********************/tests/unit-tests/GravityView_Joins_Test.php:1196

@rafaehlers rafaehlers removed their assignment Nov 19, 2024
@rafaehlers rafaehlers requested a review from mrcasual November 19, 2024 18:03
@mrcasual
Copy link
Collaborator

@zahardev, please resolve the conflict and see if you can fix the unit tests. Thanks!

@zahardev
Copy link
Contributor Author

@mrcasual This PR is outdated, so I’ll go ahead and close it.

@zahardev zahardev closed this Nov 19, 2024
@mrcasual mrcasual deleted the issue/2198-incorrect-get-entries-query branch November 19, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect get_entries() query if "Strict Entry Match" setting is disabled
4 participants