Fix unit tests on GravityForms 2.9 #2212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrcasual
reviewed
Nov 20, 2024
| @@ -476,6 +476,11 @@ private function _reset_context() { | |||
| * and second item the render instance, and third item is the reloaded entry. | |||
| */ | |||
| private function _emulate_render( $form, $view, $entry ) { | |||
| // Get clean form every test. | |||
| if ( method_exists( GFFormDisplay::class, 'flush_cached_forms' ) ) { | |||
| GFFormDisplay::flush_cached_forms(); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gravity Forms added a caching mechanism, and since we test multiple states in the same test, instead of separate tests with a data provider it hits this cache. This PR clears that cache for every
_emulate_rendercall.Also removed any lingering
GFFormsModel::is_html5_enabledcalls as that is deprecated; and has been returningtruefor a while now.💾 Build file (290e52f).