-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 2.33 #2243
Merged
Release 2.33 #2243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s convert to initials function to use in multiple places
…-user-activation-on-the-view
This PR addresses some minor things. I didn't want to push to `develop` as we are about to release. But if this is agreeable, please merge. There is a fix for the `is_approved` condition. That currently uses a `LIKE` which is the default comparator. This is somewhat slow compared to `=`, and it is prone to future errors where a status of `11` would become a thing for example as that would then also match. In addition, multiple forms already uses `=` for the joined forms. It's just the original that doesn't. Furthermore I updated the calculation of the field ID, as the can cause duplicates on the page when multiple forms are joined. Fields from other forms will still have the original form ID in the `id` attribute, which can cause duplicates if another field with that ID exists. So I swap it out with the correct form ID. The same is done for the class name, but in order to prevent BC compatibility on styling, it is ADDED instead of replaced. For the ID this could be technically Backwards Incompatible; but practically there shouldn't be two identical IDs, so that is already a problem. 💾 [Build file](https://www.dropbox.com/scl/fi/938n1f1z3ambbsk6tp6yi/gravityview-2.32-5b9dc54c4.zip?rlkey=bvlh1dopn86232hgwhko56njo&dl=1) (5b9dc54).
## Test in GF 2.8 - Confirm that the field doesn't appear in the Edit View field selector - Confirm no other issues ## Test using GF 2.9 - [ ] Confirm ability to search by Source ID in the Search Bar - [x] Confirm the Source ID field appears in the Edit View field selector - [x] By default, the Source ID field should display the ID of the page that was used to submit the form. - [x] Confirm the "Link to URL" links to that page when enabled - [x] "Link Text" setting should show only when "Link to URL" is checked - [x] Each of the "Link Text" choices should match the associated setting - [x] "Custom Text" works with custom text and merge tags
Adds a possibility to validate setting fields. Supports the following rules: required, max, min, email, integer, matches. Rules example: ``` 'validation' => [ [ 'rule' => 'required', 'message' => __( 'Field is required', 'gk-gravityview' ), ], [ 'rule' => 'max:12', 'message' => __( 'Should be less or equal 12', 'gk-gravityview' ), ], ]; ``` Currently supports only frontend validation. We can improve it with a backend validation using the same validation config. Added a "Validate URL with tags" rule for "'No Entries Redirect URL'" and "Edit Entry Redirect URL" using the "required" and "matches" rules. Here is the URL rule Regex - https://regex101.com/r/I2QSEI/1 💾 [Build file](https://www.dropbox.com/scl/fi/0cwgzmrbn8abisyorq074/gravityview-2.32-619e85cb9.zip?rlkey=nfaugp0czc32sdw3i9njx8ag4&dl=1) (619e85c).
…-format-modifier-for-sub-fields
- Implements #2186 - Important to be merged for this to work GravityKit/Event-Field#65 💾 [Build file](https://www.dropbox.com/scl/fi/ra7wjnft3bn4fsitkmbe0/gravityview-2.32-d3868963d.zip?rlkey=v9oz9xjhfmovsvxainskw7j4h&dl=1) (d386896).
…-user-activation-on-the-view
…#2180) - Implements #2076 - Adds User Activation field type to GravityView that shows ONLY WHEN User Activation is set to Manual - Makes it work using ajax in multiple and single views 💾 [Build file](https://www.dropbox.com/scl/fi/unlqo74nnxaf3n7tk6zej/gravityview-2.32-a0e94414b.zip?rlkey=56k1uhus33smpxjiigydi5dha&dl=1) (a0e9441).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This release introduces support for the Source ID meta (Gravity Forms 2.9+), adds a new User Activation field to the View editor, and includes various fixes and enhancements.
🚀 Added
:initials
merge tag modifier for Name fields to display initials.:format
merge tag modifier for field inputs (e.g.,{Event Field:1.1:format:Y-m-d}
).🐛 Fixed
🔧 Updated
💻 Developer Updates
gravityview/template/field/csv/tick
filter to programmatically modify the checkbox "check" output in CSV.gravityview/shortcode/after-processing
action after a[gravityview]
shortcode is finished.💾 Build file (e621cbb).