Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate new packaging into the role and usage of bundled openjdk #195

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

xtruthx
Copy link
Contributor

@xtruthx xtruthx commented Apr 24, 2023

Integration von new packaging

Integration of new packaging with the usage of booleans for open and enterprise package. Methods make graylog_full_version no longer optional.

Integrate usage of bundled jdk version

Make the usage of the bundled jdk version possible with leaving the java-home enviroment binary path empty.

@xtruthx
Copy link
Contributor Author

xtruthx commented Apr 24, 2023

will resolve issue #194

@xtruthx
Copy link
Contributor Author

xtruthx commented Nov 23, 2023

What is the state of progress?

@etgraylog
Copy link

Hi, thank you for the contribution and apologies for the delay. It looks good, I noticed that it needs conditionals for the tasks that install the < 5.0 plug-ins. Is it possible to add these?

@xtruthx
Copy link
Contributor Author

xtruthx commented Jan 7, 2025

Wow I didn't expect any more feedback . I am positively surprised.

I would love to continue working on the role with you. But I'm currently 4900 km away from my notebooks and computer on the Cape Verde Islands.
Now it has been so long, I would suggest we start together in the week of 27.01.2025. What do you think?

I would be happy if we could bring the entire role up to date, including with openSearch and Graylog datanode.

Regards

Übersetzt mit DeepL https://www.deepl.com/app/?utm_source=android&utm_medium=app&utm_campaign=share-translation

@etgraylog
Copy link

It-is very nice to deliver this feedback and receive such a warm response, thank you. The expression of interest in continuing to collaborate on this is also exciting!

If you would be interested in the idea, I think I could commit these conditionals to this PR and merge it before your return. And then of course thereafter focus can shift onto updating the entire role itself. What do you think?

@etgraylog etgraylog mentioned this pull request Jan 8, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants