Feature/messaging #143

frehelfer · 2023-04-12T16:53:48Z

Overview of changes

Created ChatListScreen
- It shows a List with all types of user's chats.
- Fetches from local database only the messages needed to present.
- If the user has no messages, it will display a noMessagesView.
- Shows whether the message has already been read or not.
- Update the unRead variable when the user advances in the navigation.
- Has a button to sync messages with remote server.
Created MessageScreen
- Shows all messages between user and admin.
- Fetches from db the last 40 messages and as the user scroll up it loads more.
- User can send new messages.
- New messages are saved in local data base.
- Text view container increases when the user types, after 5 lines it enable a scroll.
Created AnnounceScreen
- Shows an announcement.
Created Survey Screen
- Shows a survey with as many questions and choices as needed.
- Can only answer once, after that, it’s hidden from the user.
- If the user access the same account in another device the survey already answered will be hidden.

Screenshots (if applicable)

…w + navigation

Conflicts: TreeTracker.xcodeproj/project.pbxproj

…and maintain

…unread messages count.

… messages from planter.

… used in every viewController to change the backgroundColor.

… the messages

…when finish fetching new messages.

AlexCornforth

Thanks for your great work Fred, clear you put a lot of time and effort into this!

Left some comments to look at 🙏

TreeTracker/UI/Views/Notes/NotesViewController.swift

TreeTracker/Resources/Localizable.strings

TreeTracker/SwiftGen/Assets.swift

TreeTracker/UI/Navigation/Home/HomeCoordinator.swift

TreeTracker/UI/Views/Messaging/ChatList/ChatListViewModel.swift

TreeTracker/UI/Views/Messaging/Survey/SurveyViewModel.swift

nshutinicolas

Hey @frehelfer, I just landed on this PR after a while and while I was not able to build the app to see this first hand, I left some personal Nit changes. And from the attached video, the buttons look quite big

All in all this was massive work mate.🎉

nshutinicolas · 2023-08-21T06:04:14Z

TreeTracker/Resources/Localizable.strings

@@ -99,3 +100,25 @@
 "Settings.PhotoQuality.Option.Medium.Info" = "Medium resolution, medium data usage.";
 "Settings.PhotoQuality.Option.High.Title" = "High";
 "Settings.PhotoQuality.Option.High.Info" = "High resolution, high data usage.";
+
+//ChatList Screen
+"ChatList.SyncMessages.normal.Title" = "Sync Messages";


Nit

Suggested change

"ChatList.SyncMessages.normal.Title" = "Sync Messages";

"ChatList.SyncMessages.normal.Title" = "Update Messages";

Hey @nshutinicolas, thank you for your review!

The only way to sync the messages, both fetch and send, is through this button, so I used the word "sync" to emphasize that the messages will be brought into alignment between the user's device and the remote server, I don't know if the word "update" has the same meaning.

As English is not my main language, I don't know which one would be more suitable for this situation. What do you think?

As a dev the action is sync but as a user, they understand Refresh or update.

nshutinicolas · 2023-08-21T06:05:03Z

TreeTracker/Resources/Localizable.strings

+//ChatList Screen
+"ChatList.SyncMessages.normal.Title" = "Sync Messages";
+"ChatList.SyncMessages.loading.Title" = "Loading...";
+"ChatList.LastSyncLabel.WithouDate.Text" = "Please, tap the button above to sync messages.";


Nit

Suggested change

"ChatList.LastSyncLabel.WithouDate.Text" = "Please, tap the button above to sync messages.";

"ChatList.LastSyncLabel.WithouDate.Text" = "Please, tap the button above to update messages.";

nshutinicolas · 2023-08-21T06:05:30Z

TreeTracker/Resources/Localizable.strings

+"ChatList.SyncMessages.normal.Title" = "Sync Messages";
+"ChatList.SyncMessages.loading.Title" = "Loading...";
+"ChatList.LastSyncLabel.WithouDate.Text" = "Please, tap the button above to sync messages.";
+"ChatList.LastSyncLabel.WithDate.Text" = "Last sync time:";


Suggested change

"ChatList.LastSyncLabel.WithDate.Text" = "Last sync time:";

"ChatList.LastSyncLabel.WithDate.Text" = "Last updated:";

nshutinicolas · 2023-08-21T06:08:51Z

TreeTracker/Resources/Localizable.strings

+
+//Messages Screen
+"Messages.Title" = "Admin";
+"Messages.InputTextView.PlaceHolder" = "Click to write a message";


I always felt like click is a web term🤷🏿‍♂️. Personal preference would be Start conversation, send a message or new message

nshutinicolas · 2023-08-21T06:18:03Z

TreeTracker/UI/Views/Home/Components/UploadsButton.swift

+        } else if isHighlighted {
+            backgroundColor = Asset.Colors.secondaryOrangeDark.color
+            tintColor = .white
+        } else {
+            backgroundColor = Asset.Colors.secondaryOrangeLight.color
+            tintColor = .white


Since isEnabled and isHighlighted are different, you can put them in separate conditional statements
something like

if !isEnabled { ... } if isHighlighted { ... } else { ... }

Great! I'll make this change

nshutinicolas · 2023-08-21T06:38:23Z

TreeTracker/UI/Views/Messaging/Messages/MessagesViewController.swift

+            // TODO: Change the button icon
+            sendMessageButton.titleLabel?.font = FontFamily.Montserrat.bold.font(size: 30)
+            sendMessageButton.backgroundColor = Asset.Colors.primaryGreen.color
+            sendMessageButton.setTitle(">", for: .normal)


~~You can use SFSymbols or asset instead of this~~

Sorry just seen the todo on top

# Conflicts: # TreeTracker.xcodeproj/project.pbxproj

frehelfer and others added 13 commits April 3, 2023 14:53

implement messaging button on home view

b9639dc

clean up spaces

fa96a68

implement storyboard, view controller and view model to chat list vie…

4076fc2

…w + navigation

implement chat list table view and cell

3ddafdd

implement storyboard, view controller and view model to messages view

3cb3d45

Merge branch 'Greenstand:main' into feature/messaging

eb11464

implement messagesTableViewCell

173cf54

implement messagingService and navigation to messagesView

b0f4aad

add bell icon and some small refactor

3f56509

message view with bubbles

7b4052c

refactoring

f7e19ca

Merge branch 'main'

6f17a4d

Conflicts: TreeTracker.xcodeproj/project.pbxproj

commented some code on messageTableViewCell

a03d22e

frehelfer requested a review from AlexCornforth as a code owner April 12, 2023 16:53

frehelfer added 16 commits April 12, 2023 15:15

refactor: message alert displays numbers

538e01a

refactor: input text view grows when text get bigger

f1b563a

some design changes, added backgroundGreen Color

c6ec76b

add image to navigation bar

7e791dc

implement UITableView extension to change tableview top bounce color …

f8284e0

…and maintain

fetchMessages from home screen on viewWillAppear. Update and display …

3a46f39

…unread messages count.

small refactor on home view

62b9d70

Add messaging service to ChatList screen. Cell are working with saved…

6026c83

… messages from planter.

message view are working with saved messages from core data

8ae588a

some refactor on fetching unread messages count

238f63b

add placeholder to messages screen and fix textview autoresizing

cc25de5

move view when keyboard appears

55ad35e

fix navigation bar appearance bug with a custom extension that can be…

7cb96c5

… used in every viewController to change the backgroundColor.

add method to set unread message variable to false when the user read…

5b6ea03

… the messages

refactor preset messages mode using an array of MessageEntity

1bb58f4

create new message and save it on core data

3130adf

frehelfer added 12 commits June 2, 2023 15:09

add custom button to survey screen

37b7816

add survey logic to select a choice

937af08

added methos to create and save a new survey response

424bb05

adjust some logic to the survey flow

3d3a7bf

add scrollView to announce screen

a9bd2f3

get unread messages count on home screen

65f23fe

Change the logic to present a survey view controller

1157540

Add notification center to home screen. Updates unread message count …

8b1b70c

…when finish fetching new messages.

add darker backgroundcolor when button is highlighted

04e78e4

improve chatlist screen fetch request

af5e736

remove profile image from chatlist screen

fd0c7d4

remove setupNavigationAppearance and revert to the origin

e1d5496

AlexCornforth requested changes Aug 9, 2023

View reviewed changes

frehelfer added 9 commits August 9, 2023 16:40

changed some localizable text strings

dafa136

updated generated strings

56d80e1

removed all green background color from the project

203790c

fix indentation and camel case

18e3d18

added chatList fallback text to localizable strings

1f2eea2

removed duplicated MessageType model

cbb188c

added completion handlers for syncMessages method

9eb1e4b

removed notification center

49d50af

changed survey index to questionIndex

041b880

AlexCornforth reviewed Aug 18, 2023

View reviewed changes

TreeTracker/UI/Views/Messaging/Survey/SurveyViewModel.swift Outdated Show resolved Hide resolved

AlexCornforth reviewed Aug 18, 2023

View reviewed changes

TreeTracker/UI/Views/Messaging/Survey/SurveyViewModel.swift Outdated Show resolved Hide resolved

AlexCornforth reviewed Aug 18, 2023

View reviewed changes

TreeTracker/UI/Views/Messaging/Survey/SurveyViewModel.swift Outdated Show resolved Hide resolved

frehelfer added 2 commits August 18, 2023 10:00

added syncMessages button to chatListScreen

2851b2f

changed some methods name on surveyViewModel

e339db0

nshutinicolas reviewed Aug 21, 2023

View reviewed changes

Merge branch 'main' into feature/messaging

3d3d326

# Conflicts: # TreeTracker.xcodeproj/project.pbxproj

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/messaging #143

Feature/messaging #143

frehelfer commented Apr 12, 2023 •

edited

Loading

AlexCornforth left a comment

nshutinicolas left a comment •

edited

Loading

nshutinicolas Aug 21, 2023

frehelfer Aug 28, 2023

nshutinicolas Aug 29, 2023

nshutinicolas Aug 21, 2023

nshutinicolas Aug 21, 2023

nshutinicolas Aug 21, 2023

nshutinicolas Aug 21, 2023

frehelfer Aug 28, 2023

nshutinicolas Aug 21, 2023 •

edited

Loading

	"ChatList.SyncMessages.normal.Title" = "Sync Messages";
	"ChatList.SyncMessages.normal.Title" = "Update Messages";

	"ChatList.LastSyncLabel.WithouDate.Text" = "Please, tap the button above to sync messages.";
	"ChatList.LastSyncLabel.WithouDate.Text" = "Please, tap the button above to update messages.";

	"ChatList.LastSyncLabel.WithDate.Text" = "Last sync time:";
	"ChatList.LastSyncLabel.WithDate.Text" = "Last updated:";

Feature/messaging #143

Are you sure you want to change the base?

Feature/messaging #143

Conversation

frehelfer commented Apr 12, 2023 • edited Loading

Overview of changes

Screenshots (if applicable)

AlexCornforth left a comment

Choose a reason for hiding this comment

nshutinicolas left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nshutinicolas Aug 21, 2023 • edited Loading

Choose a reason for hiding this comment

frehelfer commented Apr 12, 2023 •

edited

Loading

nshutinicolas left a comment •

edited

Loading

nshutinicolas Aug 21, 2023 •

edited

Loading