-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ender fluid cover #2505
base: 1.20.1
Are you sure you want to change the base?
ender fluid cover #2505
Conversation
# Conflicts: # src/main/java/com/gregtechceu/gtceu/common/data/GTItems.java
src/main/java/com/gregtechceu/gtceu/common/cover/ender/CoverAbstractEnderLink.java
Outdated
Show resolved
Hide resolved
src/main/java/com/gregtechceu/gtceu/api/misc/virtualregistry/VirtualEnderRegistry.java
Outdated
Show resolved
Hide resolved
src/main/java/com/gregtechceu/gtceu/common/cover/ender/CoverAbstractEnderLink.java
Outdated
Show resolved
Hide resolved
src/main/java/com/gregtechceu/gtceu/common/cover/ender/EnderFluidLinkCover.java
Outdated
Show resolved
Hide resolved
src/main/java/com/gregtechceu/gtceu/api/misc/virtualregistry/EntryTypes.java
Outdated
Show resolved
Hide resolved
src/main/java/com/gregtechceu/gtceu/api/misc/virtualregistry/VirtualEntry.java
Outdated
Show resolved
Hide resolved
src/main/java/com/gregtechceu/gtceu/common/cover/ender/EnderFluidLinkCover.java
Outdated
Show resolved
Hide resolved
conflicts |
# Conflicts: # src/main/java/com/gregtechceu/gtceu/forge/ForgeCommonEventListener.java
Doing some testing of this, and I have some questions / comments. I have bolded the more important / buggy parts of my comment. I have opened the UI to edit from inside a machine, and the
I am curious as to why the hex for the colour has an alpha channel in it too, my only thought is that it gives more options for similar colours, but things using minecraft colours typically don't have an alpha (see other mod's ender tanks which just implement the 16 minecraft colours). Some more tooltips on the different elements of the UI would help with figuring out what stuff does. I feel like the tooltip or the image on the lock is backwards. To me the icon indicates that the cover is currently in an "unlocked" state aka public, but then the tooltip seems to indicate that clicking on the button will switch the tank to public. Maybe it should say something along the lines of: (also include a description for public when it is public, and the existing private description when it is private)
I have NOT tested this on a server yet, waiting for another PR to be merged and pulled into this PR. |
alpha and tooltip just use ceu things |
wait the tooltip is reverse .. |
because it's design to auto-delete, and if other ender cover has this channel it will be auto recreated |
Remove Do Not Merge label once this has been thoroughly tested for edge cases. |
What
This PR adds ender cover system.
Implementation Details
The implementation includes new classes for virtual cover.
Outcome
Players can now create customized virtual tanks for fluid management, enhancing the gameplay experience.